Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2482553002:
[MD Settings][People] UI polish for the easy unlock row (Closed)
|
Created:
4 years, 1 month ago by Moe Modified:
4 years, 1 month ago Reviewers:
stevenjb CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD Settings][People] UI polish for the easy unlock row
BUG=608945, 629421
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/89e14cb01bb848e376c6ffe6178b16d3d653f514
Cr-Commit-Position: refs/heads/master@{#431006}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Addressed comment #
Messages
Total messages: 21 (12 generated)
Description was changed from ========== [MD Settings][People] UI polish for the easy unlock row BUG=608945, 629421 ========== to ========== [MD Settings][People] UI polish for the easy unlock row BUG=608945, 629421 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mahmadi@chromium.org changed reviewers: + stevenjb@chromium.org
Hi Steven, Please review this CL. screenshots: https://screenshot.googleplex.com/75n0mMybzsW https://screenshot.googleplex.com/bEqXTABNgsL
https://codereview.chromium.org/2482553002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/people_page/people_page.html (right): https://codereview.chromium.org/2482553002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/people_page/people_page.html:213: easyUnlockEnabled_, easyUnlockProximityDetectionAllowed_)]]"> This is kind of awkward. We definitely shouldn't be using a somewhat arbitrary local value here (100px). Instead can we just make this two-line and use padding to ensure that taller content looks correct?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2482553002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/people_page/people_page.html (right): https://codereview.chromium.org/2482553002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/people_page/people_page.html:213: easyUnlockEnabled_, easyUnlockProximityDetectionAllowed_)]]"> On 2016/11/04 22:52:08, stevenjb wrote: > This is kind of awkward. We definitely shouldn't be using a somewhat arbitrary > local value here (100px). Instead can we just make this two-line and use padding > to ensure that taller content looks correct? Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Hi Steven, could you have another look at this? Thank you.
lgtm
On 2016/11/09 18:02:44, stevenjb wrote: > lgtm Thanks!
The CQ bit was checked by mahmadi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [MD Settings][People] UI polish for the easy unlock row BUG=608945, 629421 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Settings][People] UI polish for the easy unlock row BUG=608945, 629421 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/89e14cb01bb848e376c6ffe6178b16d3d653f514 Cr-Commit-Position: refs/heads/master@{#431006} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/89e14cb01bb848e376c6ffe6178b16d3d653f514 Cr-Commit-Position: refs/heads/master@{#431006} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
