chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java - Issue 2482533002: [Payments] Display warning messages for incomplete shipping address and update editor title

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 2482533002: [Payments] Display warning messages for incomplete shipping address and update editor title (Closed)

Patch Set: refactor function Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

index d3a9a9fa328021c0c9495814aa9a1fc2c365dda5..5069a737c5cfe6cd6329fad4052970fb026eb6e7 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

@@ -296,8 +296,7 @@ public class PaymentRequestImpl implements PaymentRequest, PaymentRequestUI.Clie

// Only suggest addresses that have a street address.

if (!TextUtils.isEmpty(profile.getStreetAddress())) {

- boolean isComplete = mAddressEditor.isProfileComplete(profile);

- addresses.add(new AutofillAddress(profile, isComplete));

+ addresses.add(new AutofillAddress(mContext, profile));

}

@@ -786,7 +785,7 @@ public class PaymentRequestImpl implements PaymentRequest, PaymentRequestUI.Clie

providePaymentInformation();

} else {

if (toEdit == null) mShippingAddressesSection.addAndSelectItem(completeAddress);

- mCardEditor.updateBillingAddress(completeAddress);

+ mCardEditor.updateBillingAddressIfComplete(completeAddress);

mClient.onShippingAddressChange(completeAddress.toPaymentAddress());

}