Remove DeviceMonitorLinux::WillDestroyCurrentMessageLoop().

Remove DeviceMonitorLinux::WillDestroyCurrentMessageLoop().

The FILE thread will soon be migrated to TaskScheduler which doesn't
support MessageLoop destruction observers.

DeviceMonitorLinux::WillDestroyCurrentMessageLoop() notified 3 observers
that the DeviceMonitorLinux MessageLoop was being destroyed. Each
observer used this notification to destroy itself.

- InputServiceLinuxImpl: This is now a leaky LazyInstance which is
  never destroyed.
- HidServiceLinux::FileThreadHelper: This is now destroyed by posting
  a delete task to the FILE thread when HidServiceLinux::Shutdown is
  called. HidServiceLinux::Shutdown is called from
  BrowserProcessImpl::StartTearDown() which is called before the
  FILE thread is teared down.
- UsbServiceLinux::FileThreadHelper: Same pattern as
  HidServiceLinux::FileThreadHelper.

BUG=650723
Committed: https://crrev.com/3b9a7a6338f1c5f393d2201f16839eb072d3c277
Cr-Commit-Position: refs/heads/master@{#431564}

[fdoray, 2016-11-04 18:45:36]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 18:46:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 19:23:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 19:23:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fdoray, 2016-11-04 20:14:18]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 20:15:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 20:49:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 20:49:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2016-11-07 21:36:28]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 21:36:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 22:07:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 22:07:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2016-11-08 14:04:28]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 14:04:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 15:09:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 15:09:02]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-11-08 15:25:43]

fdoray@chromium.org changed reviewers:
+ rockot@chromium.org

[fdoray, 2016-11-08 15:25:44]

PTAL

[Ken Rockot(use gerrit already), 2016-11-10 17:05:12]

Sorry for the delay, I missed this CL. LGTM

[fdoray, 2016-11-10 17:09:28]

fdoray@chromium.org changed reviewers:
+ achuith@chromium.org, sky@chromium.org

[fdoray, 2016-11-10 17:09:29]

achuith@: Please review changes in chrome/browser/chromeos/

sky@: Please review changes in chrome/browser/browser_process_impl.cc

Thanks!

[sky, 2016-11-10 20:27:50]

https://codereview.chromium.org/2482463002/diff/100001/chrome/browser/browser...
File chrome/browser/browser_process_impl.cc (left):

https://codereview.chromium.org/2482463002/diff/100001/chrome/browser/browser...
chrome/browser/browser_process_impl.cc:308: #if !defined(OS_ANDROID)
Why are you removing this ifdef?

[fdoray, 2016-11-10 20:41:53]

PTAnL

https://codereview.chromium.org/2482463002/diff/100001/chrome/browser/browser...
File chrome/browser/browser_process_impl.cc (left):

https://codereview.chromium.org/2482463002/diff/100001/chrome/browser/browser...
chrome/browser/browser_process_impl.cc:308: #if !defined(OS_ANDROID)
On 2016/11/10 20:27:50, sky wrote:
> Why are you removing this ifdef?

Useless since this is already in an if !defined(OS_ANDROID) block (see line
277).

[achuithb, 2016-11-10 23:24:00]

chromeos lgtm

https://codereview.chromium.org/2482463002/diff/100001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc
(right):

https://codereview.chromium.org/2482463002/diff/100001/chrome/browser/chromeo...
chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc:92:
static_cast<device::FakeInputServiceLinux*>(
Could you pull this out into a helper like
void AddDeviceForTesting(...)

[sky, 2016-11-10 23:28:05]

LGTM

[fdoray, 2016-11-11 13:09:13]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-11-11 13:09:19]

The CQ bit was unchecked by fdoray@chromium.org

[fdoray, 2016-11-11 14:21:45]

https://codereview.chromium.org/2482463002/diff/100001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc
(right):

https://codereview.chromium.org/2482463002/diff/100001/chrome/browser/chromeo...
chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc:92:
static_cast<device::FakeInputServiceLinux*>(
On 2016/11/10 23:24:00, achuithb wrote:
> Could you pull this out into a helper like
> void AddDeviceForTesting(...)

Done.

[fdoray, 2016-11-11 14:21:50]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-11-11 14:21:52]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
achuith@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2482463002/#ps120001
(title: "CR achuithb #24")

[commit-bot: I haz the power, 2016-11-11 14:22:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 15:32:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 15:32:42]

Failed to apply patch for chrome/browser/browser_process_impl.cc:
While running git apply --index -p1;
  error: patch failed: chrome/browser/browser_process_impl.cc:305
  error: chrome/browser/browser_process_impl.cc: patch does not apply

Patch:       chrome/browser/browser_process_impl.cc
Index: chrome/browser/browser_process_impl.cc
diff --git a/chrome/browser/browser_process_impl.cc
b/chrome/browser/browser_process_impl.cc
index
3066504299868e9104db0311eef627697415c292..673377eccdd755d5bf5280cca67e75e887fabf58
100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -305,11 +305,12 @@ void BrowserProcessImpl::StartTearDown() {
   // so it needs to be shut down before the ProfileManager.
   supervised_user_whitelist_installer_.reset();
 
-#if !defined(OS_ANDROID)
   // Debugger must be cleaned up before ProfileManager.
   remote_debugging_server_.reset();
   devtools_auto_opener_.reset();
-#endif
+
+  // ChromeDeviceClient must be shutdown when the FILE thread is still alive.
+  device_client_->Shutdown();
 
   // Need to clear profiles (download managers) before the io_thread_.
   {

[commit-bot: I haz the power, 2016-11-11 15:34:01]

Description was changed from

==========
Remove DeviceMonitorLinux::WillDestroyCurrentMessageLoop().

The FILE thread will soon be migrated to TaskScheduler which doesn't
support MessageLoop destruction observers.

DeviceMonitorLinux::WillDestroyCurrentMessageLoop() notified 3 observers
that the DeviceMonitorLinux MessageLoop was being destroyed. Each
observer used this notification to destroy itself.

- InputServiceLinuxImpl: This is now a leaky LazyInstance which is
  never destroyed.
- HidServiceLinux::FileThreadHelper: This is now destroyed by posting
  a delete task to the FILE thread when HidServiceLinux::Shutdown is
  called. HidServiceLinux::Shutdown is called from
  BrowserProcessImpl::StartTearDown() which is called before the
  FILE thread is teared down.
- UsbServiceLinux::FileThreadHelper: Same pattern as
  HidServiceLinux::FileThreadHelper.

BUG=650723
==========

to

==========
Remove DeviceMonitorLinux::WillDestroyCurrentMessageLoop().

The FILE thread will soon be migrated to TaskScheduler which doesn't
support MessageLoop destruction observers.

DeviceMonitorLinux::WillDestroyCurrentMessageLoop() notified 3 observers
that the DeviceMonitorLinux MessageLoop was being destroyed. Each
observer used this notification to destroy itself.

- InputServiceLinuxImpl: This is now a leaky LazyInstance which is
  never destroyed.
- HidServiceLinux::FileThreadHelper: This is now destroyed by posting
  a delete task to the FILE thread when HidServiceLinux::Shutdown is
  called. HidServiceLinux::Shutdown is called from
  BrowserProcessImpl::StartTearDown() which is called before the
  FILE thread is teared down.
- UsbServiceLinux::FileThreadHelper: Same pattern as
  HidServiceLinux::FileThreadHelper.

BUG=650723

Committed: https://crrev.com/3b9a7a6338f1c5f393d2201f16839eb072d3c277
Cr-Commit-Position: refs/heads/master@{#431564}
==========

[commit-bot: I haz the power, 2016-11-11 15:34:03]

Patchset 7 (id:??) landed as
https://crrev.com/3b9a7a6338f1c5f393d2201f16839eb072d3c277
Cr-Commit-Position: refs/heads/master@{#431564}