content/common/input/input_event_ack_location.h - Issue 2482453002: Don't restart the hang renderer timeout on messages ack'd from the compositor thread.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/input/input_event_ack_location.h

Issue 2482453002: Don't restart the hang renderer timeout on messages ack'd from the compositor thread. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_COMMON_INPUT_INPUT_EVENT_ACK_LOCATION_H_

	6 #define CONTENT_COMMON_INPUT_INPUT_EVENT_ACK_LOCATION_H_

	7

	8 namespace content {

	9

	10 // Describes the location of where the input event ACK was

	11 // generated to the browser from the renderer.

	12 enum class InputEventAckLocation {
	tdresser 2016/11/04 18:35:54 I'd prefer InputEventAckSource, as it makes it cle I'd prefer InputEventAckSource, as it makes it clear you're referring to where the ack was generated, rather than where it currently is. This comment is a bit confusing. Where the ack was "generated to" the browser? What does that mean? dtapuska 2016/11/04 20:14:16 Done. Show quoted text On 2016/11/04 18:35:54, tdresser wrote: > I'd prefer InputEventAckSource, as it makes it clear you're referring to where > the ack was generated, rather than where it currently is. > > This comment is a bit confusing. > > Where the ack was "generated to" the browser? What does that mean? Done.
	13 INPUT_EVENT_ACK_LOCATION_UNKNOWN,
	dcheng 2016/11/04 18:24:49 Nit: since this is an enum class, just omit the IN Nit: since this is an enum class, just omit the INPUT_EVENT_ACK_LOCATION_ prefix dtapuska 2016/11/04 20:14:16 Done. Show quoted text On 2016/11/04 18:24:49, dcheng wrote: > Nit: since this is an enum class, just omit the INPUT_EVENT_ACK_LOCATION_ prefix Done.
	14 INPUT_EVENT_ACK_LOCATION_COMPOSITOR_THREAD,

	15 INPUT_EVENT_ACK_LOCATION_MAIN_THREAD,

	16 INPUT_EVENT_ACK_LOCATION_MAX = INPUT_EVENT_ACK_LOCATION_MAIN_THREAD

	17 };

	18

	19 } // namespace content

	20

	21 #endif // CONTENT_COMMON_INPUT_INPUT_EVENT_ACK_LOCATION_H_

OLD	NEW

« no previous file with comments | « content/common/input/input_event_ack.cc ('k') | content/common/input_messages.h » ('j') | content/renderer/mus/compositor_mus_connection_unittest.cc » ('J')