Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2482443002: Fix a 'promise_test' bug in 'http/tests/credentialmanager/passwordcredential-fetch.html'. (Closed)

Created:
4 years, 1 month ago by Mike West
Modified:
4 years, 1 month ago
Reviewers:
tkent, foolip
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a 'promise_test' bug in 'http/tests/credentialmanager/passwordcredential-fetch.html'. BUG=662172 Committed: https://crrev.com/4fec1897a4e384361a8f514a703211864f3dee94 Cr-Commit-Position: refs/heads/master@{#430243}

Patch Set 1 #

Patch Set 2 : Expectation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -25 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch-expected.txt View 1 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Mike West
This test shouldn't have been a `promise_test`. Let's fix it, shall we? Would one of ...
4 years, 1 month ago (2016-11-04 17:00:28 UTC) #2
foolip
lgtm
4 years, 1 month ago (2016-11-04 17:01:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482443002/1
4 years, 1 month ago (2016-11-04 17:02:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/325836)
4 years, 1 month ago (2016-11-04 18:07:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482443002/20001
4 years, 1 month ago (2016-11-07 08:54:08 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-07 09:45:20 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 09:47:46 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4fec1897a4e384361a8f514a703211864f3dee94
Cr-Commit-Position: refs/heads/master@{#430243}

Powered by Google App Engine
This is Rietveld 408576698