Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2482423003: PassThroughImageTransportSurface: Remove unused parameter (Closed)

Created:
4 years, 1 month ago by Fady Samuel
Modified:
4 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PassThroughImageTransportSurface: Remove unused parameter PassThroughImageTransportSurface takes in a GpuChannelManager but never uses it. This CL removes that parameter. BUG=661278 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/38fe0daf2860dd26726c47a2bf96647d3b5842d2 Cr-Commit-Position: refs/heads/master@{#430955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M gpu/ipc/service/image_transport_surface_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/image_transport_surface_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/image_transport_surface_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/image_transport_surface_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/pass_through_image_transport_surface.h View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/ipc/service/pass_through_image_transport_surface.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Fady Samuel
It looks like PassThroughImageTransportSurface creates and passes around LatencyInfo which we'll want to preserve in ...
4 years, 1 month ago (2016-11-09 16:08:54 UTC) #5
piman
lgtm
4 years, 1 month ago (2016-11-09 16:25:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482423003/1
4 years, 1 month ago (2016-11-09 17:01:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 17:07:19 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 17:10:08 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38fe0daf2860dd26726c47a2bf96647d3b5842d2
Cr-Commit-Position: refs/heads/master@{#430955}

Powered by Google App Engine
This is Rietveld 408576698