core/fxcrt/fx_system.h - Issue 2482373002: Define IsFloatEqual macro properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/fx_system.h

Issue 2482373002: Define IsFloatEqual macro properly. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcrt/fx_system.h

diff --git a/core/fxcrt/fx_system.h b/core/fxcrt/fx_system.h

index d3f488a33abc94f29147b65c5cb4a6f85cf30c54..c31bef974fe06f42d63d66d2d5751596f6d62e32 100644

--- a/core/fxcrt/fx_system.h

+++ b/core/fxcrt/fx_system.h

@@ -76,7 +76,7 @@ typedef wchar_t FX_WCHAR; // Keep, maybe bad platform wchars.

#define IsFloatZero(f) ((f) < 0.0001 && (f) > -0.0001)

#define IsFloatBigger(fa, fb) ((fa) > (fb) && !IsFloatZero((fa) - (fb)))

#define IsFloatSmaller(fa, fb) ((fa) < (fb) && !IsFloatZero((fa) - (fb)))

-#define IsFloatEqual(fa, fb) IsFloatZero(fa - fb)

+#define IsFloatEqual(fa, fb) IsFloatZero((fa) - (fb))

dsinclair 2016/11/09 03:33:23 Should these just be real methods instead of macro

Lei Zhang 2016/11/09 05:34:09 We can, but the behavior of this CL won't change f

// PDFium string sizes are limited to 2^31-1, and the value is signed to

// allow -1 as a placeholder for "unknown".

« no previous file with comments | « no previous file | no next file » | no next file with comments »