|
Revert of Tracking filter mutation via SVGElementProxy (patchset #15 id:280001 of https://codereview.chromium.org/2401343002/ )
Reason for revert:
There are several reports of issues from this patch. Lets go ahead and roll out for now.
BUG= 663362, 663444, 663473, 663362
Original issue's description:
> Tracking reference filter mutation via SVGElementProxy
>
> This introduces SVGElementProxy - a new piece with the functionality of
> DocumentResourceReference and the ReferenceFilterBuilder merged. It
> provides the means to track clients of a certain element (only
> SVGFilterElements for now, but will likely be extended to other types if
> it ends up sticking.) An SVGElementProxy is created, and primarily owned,
> by CSSURIValue. The proxy also handles loading of a resource document, if
> requested.
>
> Clients are SVGResourceClients, like before, with methods/callbacks
> renamed. Some of the old functionality of SVGResourceClient has either
> been moved to clients, to the proxy or been replaced with different
> solutions.
>
> Mutations to the element/subtree is signaled separately from any
> potential changes to the actual reference (anything that might invalidate
> the element reference.)
>
> BUG= 439970
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/d36f8a8c9c4b7d757c0d8832e624be80c4465991
> Cr-Commit-Position: refs/heads/master@{#430550}
TBR=esprehn@chromium.org,fs@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 439970, 663362, 663444, 663473, 663362
Committed: https://crrev.com/11759c7f36706a115c03b9fc98a6060dd73a71e9
Cr-Commit-Position: refs/heads/master@{#430800}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+698 lines, -598 lines) |
Patch |
 |
M |
third_party/WebKit/Source/core/css/CSSURIValue.h
|
View
|
|
1 chunk |
+8 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/css/CSSURIValue.cpp
|
View
|
|
2 chunks |
+15 lines, -15 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h
|
View
|
|
3 chunks |
+5 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/css/resolver/ElementStyleResources.cpp
|
View
|
|
3 chunks |
+24 lines, -11 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp
|
View
|
|
2 chunks |
+15 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/Document.h
|
View
|
|
4 chunks |
+12 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/Document.cpp
|
View
|
|
4 chunks |
+31 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/Element.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/Element.cpp
|
View
|
|
3 chunks |
+9 lines, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/Node.h
|
View
|
|
3 chunks |
+27 lines, -16 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/Node.cpp
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/StyleChangeReason.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/StyleChangeReason.cpp
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/fetch/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
A |
third_party/WebKit/Source/core/fetch/DocumentResourceReference.h
|
View
|
|
1 chunk |
+62 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/frame/FrameView.cpp
|
View
|
|
1 chunk |
+13 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/svg/BUILD.gn
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h
|
View
|
|
4 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp
|
View
|
|
7 chunks |
+47 lines, -20 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.cpp
|
View
|
|
2 chunks |
+1 line, -5 lines |
0 comments
|
Download
|
 |
A |
third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.h
|
View
|
|
1 chunk |
+60 lines, -0 lines |
0 comments
|
Download
|
 |
A |
third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp
|
View
|
|
1 chunk |
+95 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp
|
View
|
|
2 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/paint/PaintLayer.h
|
View
|
|
6 chunks |
+7 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/paint/PaintLayer.cpp
|
View
|
|
11 chunks |
+73 lines, -31 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/paint/PaintLayerFilterInfo.h
|
View
|
|
2 chunks |
+4 lines, -6 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/paint/PaintLayerFilterInfo.cpp
|
View
|
|
2 chunks |
+8 lines, -22 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/style/FilterOperation.h
|
View
|
|
3 chunks |
+14 lines, -13 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/style/FilterOperation.cpp
|
View
|
|
3 chunks |
+0 lines, -22 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/style/FilterOperations.h
|
View
|
|
2 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/style/FilterOperations.cpp
|
View
|
|
2 chunks |
+3 lines, -14 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/svg/BUILD.gn
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h
|
View
|
|
2 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/Source/core/svg/SVGElementProxy.h
|
View
|
|
1 chunk |
+0 lines, -138 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/Source/core/svg/SVGElementProxy.cpp
|
View
|
|
1 chunk |
+0 lines, -193 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/svg/SVGFilterElement.h
|
View
|
|
3 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/svg/SVGFilterElement.cpp
|
View
|
|
4 chunks |
+17 lines, -7 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/svg/SVGResourceClient.h
|
View
|
|
1 chunk |
+18 lines, -9 lines |
0 comments
|
Download
|
 |
A |
third_party/WebKit/Source/core/svg/SVGResourceClient.cpp
|
View
|
|
1 chunk |
+86 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
|
View
|
|
3 chunks |
+1 line, -8 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
|
View
|
|
2 chunks |
+1 line, -23 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
|
View
|
|
2 chunks |
+9 lines, -1 line |
0 comments
|
Download
|
Total messages: 8 (3 generated)
|