arc: bluetooth: Replace nullptr with "" for mojo::String

arc: bluetooth: Don't use nullptr with device name

Don't use nullptr with the device name in mojo types below
as they are not defined as nullable in mojom file.
- mojom::BluetoothProperty.bdname
- mojom::BluetoothAdvertisingData.local_name

This fixes Chrome crash in recent build because of the
Bluetooth API change in http://crrev.com/2440043002
that make the device name optional. Before that, GetName()
will returns MAC address when there is no device name.

BUG=663096
TEST=minnie won't crash when scan for new BT device.
     nRF connect app still has same behavior.

Committed: https://crrev.com/68561070668c0f84a0cb2d3d9fc70129fb5ede1b
Cr-Commit-Position: refs/heads/master@{#430789}

[puthik_chromium, 2016-11-08 22:43:20]

The CQ bit was checked by puthik@chromium.org to run a CQ dry run

[puthik_chromium, 2016-11-08 22:44:02]

puthik@chromium.org changed reviewers:
+ lhchavez@chromium.org

[commit-bot: I haz the power, 2016-11-08 22:44:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Luis Héctor Chávez, 2016-11-08 22:45:23]

Hmmm, can there be a bit more investigation about the crash? "Something" does
not seem like a good explanation.

[Luis Héctor Chávez, 2016-11-08 23:24:29]

discussed offline. as long as the commit description is changed to something a
bit more informative, lgtm.

[commit-bot: I haz the power, 2016-11-08 23:46:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 23:46:44]

Dry run: This issue passed the CQ dry run.

[puthik_chromium, 2016-11-09 00:12:18]

Description was changed from

==========
arc: bluetooth: Replace nullptr with "" for mojo::String

Something (probably compiler settings change or mojo change) causes
mojo::String to crash when set the data with nullptr. This patch
changes nullptr to empty string ("") for mojo::String.

BUG=663096
TEST=minnie won't crash when scan for new BT device.
     nRF connect app still has same behavior.
==========

to

==========
arc: bluetooth: Don't use nullptr with device name

Don't use nullptr with the device name in mojo types below
as they are not defined as nullable in mojom file.
- mojom::BluetoothProperty.bdname
- mojom::BluetoothAdvertisingData.local_name

This fixes Chrome crash in recent build because of the
Bluetooth API change in http://crrev.com/2440043002
that make the device name optional. Before that, getName()
will returns MAC address when there is no device name.

BUG=663096
TEST=minnie won't crash when scan for new BT device.
     nRF connect app still has same behavior.
==========

[puthik_chromium, 2016-11-09 00:13:10]

The CQ bit was checked by puthik@chromium.org

[commit-bot: I haz the power, 2016-11-09 00:13:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[puthik_chromium, 2016-11-09 00:14:28]

Found the root cause. Commit message updated.

[puthik_chromium, 2016-11-09 00:15:13]

Description was changed from

==========
arc: bluetooth: Don't use nullptr with device name

Don't use nullptr with the device name in mojo types below
as they are not defined as nullable in mojom file.
- mojom::BluetoothProperty.bdname
- mojom::BluetoothAdvertisingData.local_name

This fixes Chrome crash in recent build because of the
Bluetooth API change in http://crrev.com/2440043002
that make the device name optional. Before that, getName()
will returns MAC address when there is no device name.

BUG=663096
TEST=minnie won't crash when scan for new BT device.
     nRF connect app still has same behavior.
==========

to

==========
arc: bluetooth: Don't use nullptr with device name

Don't use nullptr with the device name in mojo types below
as they are not defined as nullable in mojom file.
- mojom::BluetoothProperty.bdname
- mojom::BluetoothAdvertisingData.local_name

This fixes Chrome crash in recent build because of the
Bluetooth API change in http://crrev.com/2440043002
that make the device name optional. Before that, GetName()
will returns MAC address when there is no device name.

BUG=663096
TEST=minnie won't crash when scan for new BT device.
     nRF connect app still has same behavior.
==========

[commit-bot: I haz the power, 2016-11-09 00:28:33]

Description was changed from

==========
arc: bluetooth: Don't use nullptr with device name

Don't use nullptr with the device name in mojo types below
as they are not defined as nullable in mojom file.
- mojom::BluetoothProperty.bdname
- mojom::BluetoothAdvertisingData.local_name

This fixes Chrome crash in recent build because of the
Bluetooth API change in http://crrev.com/2440043002
that make the device name optional. Before that, GetName()
will returns MAC address when there is no device name.

BUG=663096
TEST=minnie won't crash when scan for new BT device.
     nRF connect app still has same behavior.
==========

to

==========
arc: bluetooth: Don't use nullptr with device name

Don't use nullptr with the device name in mojo types below
as they are not defined as nullable in mojom file.
- mojom::BluetoothProperty.bdname
- mojom::BluetoothAdvertisingData.local_name

This fixes Chrome crash in recent build because of the
Bluetooth API change in http://crrev.com/2440043002
that make the device name optional. Before that, GetName()
will returns MAC address when there is no device name.

BUG=663096
TEST=minnie won't crash when scan for new BT device.
     nRF connect app still has same behavior.
==========

[commit-bot: I haz the power, 2016-11-09 00:28:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-09 00:35:41]

Description was changed from

==========
arc: bluetooth: Don't use nullptr with device name

Don't use nullptr with the device name in mojo types below
as they are not defined as nullable in mojom file.
- mojom::BluetoothProperty.bdname
- mojom::BluetoothAdvertisingData.local_name

This fixes Chrome crash in recent build because of the
Bluetooth API change in http://crrev.com/2440043002
that make the device name optional. Before that, GetName()
will returns MAC address when there is no device name.

BUG=663096
TEST=minnie won't crash when scan for new BT device.
     nRF connect app still has same behavior.
==========

to

==========
arc: bluetooth: Don't use nullptr with device name

Don't use nullptr with the device name in mojo types below
as they are not defined as nullable in mojom file.
- mojom::BluetoothProperty.bdname
- mojom::BluetoothAdvertisingData.local_name

This fixes Chrome crash in recent build because of the
Bluetooth API change in http://crrev.com/2440043002
that make the device name optional. Before that, GetName()
will returns MAC address when there is no device name.

BUG=663096
TEST=minnie won't crash when scan for new BT device.
     nRF connect app still has same behavior.

Committed: https://crrev.com/68561070668c0f84a0cb2d3d9fc70129fb5ede1b
Cr-Commit-Position: refs/heads/master@{#430789}
==========

[commit-bot: I haz the power, 2016-11-09 00:35:41]

Patchset 1 (id:??) landed as
https://crrev.com/68561070668c0f84a0cb2d3d9fc70129fb5ede1b
Cr-Commit-Position: refs/heads/master@{#430789}