Issue 2482283003: [chromedriver] Don't generate char events on Mac for KeyConverter.AllShorthandKeys.

Issue 2482283003: [chromedriver] Don't generate char events on Mac for KeyConverter.AllShorthandKeys. (Closed)

Created:
4 years, 1 month ago by samuong

Modified:
4 years, 1 month ago

Reviewers:
stgao

CC:
chromium-reviews, samuong+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[chromedriver] Don't generate char events on Mac for KeyConverter.AllShorthandKeys. BUG=chromedriver:1502 Committed: https://crrev.com/53fce1eef5b00333b512d3de47028e13fce09a66 Cr-Commit-Position: refs/heads/master@{#430764}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	chrome/test/chromedriver/key_converter_unittest.cc	View		1 chunk	+14 lines, -2 lines	0 comments	Download

Total messages: 8 (3 generated)

samuong

This CL adds back some #ifdefs that were lost in crrev.com/429386, and are causing tests ...

4 years, 1 month ago (2016-11-08 23:10:34 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482283003/1

4 years, 1 month ago (2016-11-08 23:18:23 UTC) #5

commit-bot: I haz the power

4 years, 1 month ago (2016-11-08 23:45:35 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/53fce1eef5b00333b512d3de47028e13fce09a66
Cr-Commit-Position: refs/heads/master@{#430764}