Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1336)

Issue 2482263004: Fix a possible flaky ServiceWorkerNavigationPreloadTest. (Closed)

Created:
4 years, 1 month ago by horo
Modified:
4 years, 1 month ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org, yhirano
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a possible flaky ServiceWorkerNavigationPreloadTest. The navigation preload request of NetworkFallback test case may be canceled before reaching the server. BUG=649558 Committed: https://crrev.com/43f1473aef1be26452946a69fb1446bea4cf28a6 Cr-Commit-Position: refs/heads/master@{#430889}

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/reqeust/request/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 1 1 chunk +16 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
horo
falken@ Please review this.
4 years, 1 month ago (2016-11-09 05:23:57 UTC) #4
falken
lgtm https://codereview.chromium.org/2482263004/diff/1/content/browser/service_worker/service_worker_browsertest.cc File content/browser/service_worker/service_worker_browsertest.cc (right): https://codereview.chromium.org/2482263004/diff/1/content/browser/service_worker/service_worker_browsertest.cc#newcode1637 content/browser/service_worker/service_worker_browsertest.cc:1637: // - A navigation preload reqeust may be ...
4 years, 1 month ago (2016-11-09 05:32:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482263004/20001
4 years, 1 month ago (2016-11-09 05:37:14 UTC) #9
horo
https://codereview.chromium.org/2482263004/diff/1/content/browser/service_worker/service_worker_browsertest.cc File content/browser/service_worker/service_worker_browsertest.cc (right): https://codereview.chromium.org/2482263004/diff/1/content/browser/service_worker/service_worker_browsertest.cc#newcode1637 content/browser/service_worker/service_worker_browsertest.cc:1637: // - A navigation preload reqeust may be sent. ...
4 years, 1 month ago (2016-11-09 05:37:24 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-09 08:13:49 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 08:16:23 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/43f1473aef1be26452946a69fb1446bea4cf28a6
Cr-Commit-Position: refs/heads/master@{#430889}

Powered by Google App Engine
This is Rietveld 408576698