Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1790)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutProvider.java

Issue 2482233002: Remove visible viewport dependency in CompositorView (Closed)
Patch Set: remove unneeded override Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutProvider.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutProvider.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutProvider.java
index 7805363f24f683ca115864c8f32d245564077b05..9a20a12d0a0ba348388200f6b2e1c1a2561c5a06 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutProvider.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutProvider.java
@@ -28,16 +28,14 @@ public interface LayoutProvider {
/**
* @param rect RectF instance to be used to store the result and return. If null, it uses a new
* RectF instance.
- * @return The rectangle of the layout in its View in dp.
*/
- RectF getViewportDp(RectF rect);
+ void getViewportDp(RectF rect);
/**
* @param rect Rect instance to be used to store the result and return. If null, it uses a new
* Rect instance.
- * @return The rectangle of the layout in its View in pixels.
*/
- Rect getViewportPixel(Rect rect);
+ void getViewportPixel(Rect rect);
/**
* @return The manager in charge of handling fullscreen changes.
@@ -49,7 +47,6 @@ public interface LayoutProvider {
* it and return it.
*
* @param viewport A viewport in which to display content.
- * @param contentViewport The visible section of the viewport.
* @param layerTitleCache A layer title cache.
* @param tabContentManager A tab content manager.
* @param resourceManager A resource manager.
@@ -57,7 +54,7 @@ public interface LayoutProvider {
* @return A {@link SceneLayer} that represents the content for this
* {@link Layout}.
*/
- SceneLayer getUpdatedActiveSceneLayer(Rect viewport, Rect contentViewport,
- LayerTitleCache layerTitleCache, TabContentManager tabContentManager,
- ResourceManager resourceManager, ChromeFullscreenManager fullscreenManager);
+ SceneLayer getUpdatedActiveSceneLayer(Rect viewport, LayerTitleCache layerTitleCache,
+ TabContentManager tabContentManager, ResourceManager resourceManager,
+ ChromeFullscreenManager fullscreenManager);
}

Powered by Google App Engine
This is Rietveld 408576698