Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4676)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

Issue 2482233002: Remove visible viewport dependency in CompositorView (Closed)
Patch Set: remove unneeded override Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
index 384e7e2da44199838648a32dcaa232a2d83ca727..009f2bd929ca36da9ee9474cf610c5cdb40ca568 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
@@ -73,7 +73,8 @@ import java.util.List;
* drawn by the UI compositor on the native side.
*/
public class CompositorViewHolder extends CoordinatorLayout
- implements LayoutManagerHost, LayoutRenderHost, Invalidator.Host, FullscreenListener {
+ implements ContentOffsetProvider, LayoutManagerHost, LayoutRenderHost, Invalidator.Host,
+ FullscreenListener {
private boolean mIsKeyboardShowing = false;
@@ -313,10 +314,6 @@ public class CompositorViewHolder extends CoordinatorLayout
return mCompositorView.getResourceManager();
}
- public ContentOffsetProvider getContentOffsetProvider() {
- return mCompositorView;
- }
-
/**
* @return The {@link DynamicResourceLoader} for registering resources.
*/
@@ -642,16 +639,6 @@ public class CompositorViewHolder extends CoordinatorLayout
propagateViewportToLayouts(getWidth(), getHeight());
}
- /**
- * Note that the returned rect is reused for other calls.
- */
- @Override
- public Rect getVisibleViewport(Rect rect) {
- if (rect == null) rect = new Rect();
- rect.set(0, (int) mLastVisibleContentOffset, getWidth(), getHeight());
- return rect;
- }
-
@Override
public int getBrowserControlsBackgroundColor() {
return mTabVisible == null ? Color.WHITE : mTabVisible.getThemeColor();
@@ -675,6 +662,13 @@ public class CompositorViewHolder extends CoordinatorLayout
return mFullscreenManager != null ? mFullscreenManager.getBrowserControlsHeight() : 0;
}
+ @Override
+ public int getOverlayTranslateY() {
+ return areBrowserControlsPermanentlyHidden()
+ ? getBrowserControlsHeightPixels()
+ : mCacheVisibleViewport.top;
+ }
+
/**
* Sets the URL bar. This is needed so that the ContentViewHolder can find out
* whether it can claim focus.

Powered by Google App Engine
This is Rietveld 408576698