Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2482173002: [ios] Adds OmahaServiceProvider. (Closed)

Created:
4 years, 1 month ago by rohitrao (ping after 24h)
Modified:
4 years, 1 month ago
Reviewers:
sdefresne
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds OmahaServiceProvider. BUG=663349 Committed: https://crrev.com/8d1d54f408fb245877370369319ae0638a6d3dcd Cr-Commit-Position: refs/heads/master@{#430682}

Patch Set 1 #

Patch Set 2 : Add provider. #

Total comments: 1

Patch Set 3 : XML #

Messages

Total messages: 20 (12 generated)
rohitrao (ping after 24h)
4 years, 1 month ago (2016-11-08 14:24:25 UTC) #5
sdefresne
https://codereview.chromium.org/2482173002/diff/20001/ios/public/provider/chrome/browser/omaha/omaha_service_provider.h File ios/public/provider/chrome/browser/omaha/omaha_service_provider.h (right): https://codereview.chromium.org/2482173002/diff/20001/ios/public/provider/chrome/browser/omaha/omaha_service_provider.h#newcode20 ios/public/provider/chrome/browser/omaha/omaha_service_provider.h:20: virtual std::string GetUpdateServerURL() const; nit: either return GURL or ...
4 years, 1 month ago (2016-11-08 14:31:50 UTC) #8
sdefresne
lgtm
4 years, 1 month ago (2016-11-08 14:31:56 UTC) #9
rohitrao (ping after 24h)
Updated with a new API.
4 years, 1 month ago (2016-11-08 14:50:40 UTC) #12
sdefresne
lgtm
4 years, 1 month ago (2016-11-08 16:49:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482173002/40001
4 years, 1 month ago (2016-11-08 18:33:32 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-08 19:22:38 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 19:39:46 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8d1d54f408fb245877370369319ae0638a6d3dcd
Cr-Commit-Position: refs/heads/master@{#430682}

Powered by Google App Engine
This is Rietveld 408576698