Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

Issue 2482153003: DevTools: Depict network request timings on timeline network pane. (Closed)
Patch Set: Tweaks Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
index 987ae4ddad0064d1474195ebc91bdae49ed3cbcc..93454423681a2f32f85f60fb9fe64c489ae10721 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
@@ -1391,6 +1391,14 @@ WebInspector.TimelineModel.NetworkRequest = class {
this.endTime = Infinity;
/** @type {!Array<!WebInspector.TracingModel.Event>} */
this.children = [];
+ /** @type {?Object} */
+ this.timing;
+ /** @type {string} */
+ this.mimeType;
+ /** @type {string} */
+ this.url;
+ /** @type {string} */
+ this.requestMethod;
this.addEvent(event);
}
@@ -1408,6 +1416,8 @@ WebInspector.TimelineModel.NetworkRequest = class {
this.priority = eventData['priority'];
if (event.name === recordType.ResourceFinish)
this.endTime = event.startTime;
+ if (eventData['finishTime'])
+ this.finishTime = eventData['finishTime'] * 1000;
if (!this.responseTime &&
(event.name === recordType.ResourceReceiveResponse || event.name === recordType.ResourceReceivedData))
this.responseTime = event.startTime;
@@ -1415,6 +1425,8 @@ WebInspector.TimelineModel.NetworkRequest = class {
this.url = eventData['url'];
if (!this.requestMethod)
this.requestMethod = eventData['requestMethod'];
+ if (!this.timing)
+ this.timing = eventData['timing'];
}
};

Powered by Google App Engine
This is Rietveld 408576698