Fix regression in annotation key event handling.

Fix regression in annotation key event handling.

BUG=chromium:663294
Committed: https://pdfium.googlesource.com/pdfium/+/7b3252fa1f282c01707fc53d0ac347878dd0aebb

[Lei Zhang, 2016-11-08 10:54:50]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 10:54:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-11-08 10:55:40]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Lei Zhang, 2016-11-08 10:55:40]

Look at the original logic in
https://codereview.chromium.org/2273893002/diff/140001/fpdfsdk/cpdfsdk_annoth...,
look at the new code, stare a bit more...

[commit-bot: I haz the power, 2016-11-08 11:54:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 11:54:45]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-11-09 03:36:21]

https://codereview.chromium.org/2482143002/diff/1/fpdfsdk/cpdfsdk_annothandle...
File fpdfsdk/cpdfsdk_annothandlermgr.cpp (right):

https://codereview.chromium.org/2482143002/diff/1/fpdfsdk/cpdfsdk_annothandle...
fpdfsdk/cpdfsdk_annothandlermgr.cpp:214: return
GetAnnotHandler(pAnnot)->OnKeyDown(pAnnot, nKeyCode, nFlag);
Do you need to null check GetAnnotHandler as the original code did?

[Lei Zhang, 2016-11-09 05:28:29]

https://codereview.chromium.org/2482143002/diff/1/fpdfsdk/cpdfsdk_annothandle...
File fpdfsdk/cpdfsdk_annothandlermgr.cpp (right):

https://codereview.chromium.org/2482143002/diff/1/fpdfsdk/cpdfsdk_annothandle...
fpdfsdk/cpdfsdk_annothandlermgr.cpp:214: return
GetAnnotHandler(pAnnot)->OnKeyDown(pAnnot, nKeyCode, nFlag);
On 2016/11/09 03:36:21, dsinclair wrote:
> Do you need to null check GetAnnotHandler as the original code did?

No, GetAnnotHandler() never returns nullptr.

[dsinclair, 2016-11-09 05:29:49]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-09 05:29:49]

lgtm

[commit-bot: I haz the power, 2016-11-09 05:29:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 05:30:13]

Description was changed from

==========
Fix regression in annotation key event handling.

BUG=chromium:663294
==========

to

==========
Fix regression in annotation key event handling.

BUG=chromium:663294

Committed:
https://pdfium.googlesource.com/pdfium/+/7b3252fa1f282c01707fc53d0ac347878dd0...
==========

[commit-bot: I haz the power, 2016-11-09 05:30:14]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/7b3252fa1f282c01707fc53d0ac347878dd0...