[debugger] do not accidentally pop contexts in bytecode

[debugger] do not accidentally pop contexts in bytecode

R=jgruber@chromium.org, mstarzinger@chromium.org
BUG=v8:5610
Committed: https://crrev.com/a168eb15bc2f5d9d78c631cbe66fdfa914e484b7
Cr-Commit-Position: refs/heads/master@{#40827}

[Yang, 2016-11-08 11:32:24]

yangguo@chromium.org changed reviewers:
+ rmcilroy@chromium.org
- jgruber@chromium.org

[Yang, 2016-11-08 11:32:24]

Please take a look. Popping context before return confuses the debugger .

[Yang, 2016-11-08 11:32:30]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 11:32:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-11-08 11:34:29]

Description was changed from

==========
[debugger] expect popped context in bytecode when inspecting scopes.

R=jgruber@chromium.org, mstarzinger@chromium.org
BUG=v8:5610
==========

to

==========
[debugger] do not accidentally pop contexts in bytecode

R=jgruber@chromium.org, mstarzinger@chromium.org
BUG=v8:5610
==========

[commit-bot: I haz the power, 2016-11-08 11:57:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 11:57:09]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-11-08 12:02:45]

LGTM, thanks.

[Yang, 2016-11-08 12:11:16]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-11-08 12:11:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 12:13:26]

Description was changed from

==========
[debugger] do not accidentally pop contexts in bytecode

R=jgruber@chromium.org, mstarzinger@chromium.org
BUG=v8:5610
==========

to

==========
[debugger] do not accidentally pop contexts in bytecode

R=jgruber@chromium.org, mstarzinger@chromium.org
BUG=v8:5610
==========

[commit-bot: I haz the power, 2016-11-08 12:13:27]

Committed patchset #2 (id:20001)

[jgruber, 2016-11-08 12:29:16]

On 2016/11/08 11:32:24, Yang wrote:
> Please take a look. Popping context before return confuses the debugger .

We will need to clean up the directory structure in test/debugger at some point.
For instance, right now we have t/d/debug/regress and t/d/regress.

[Yang, 2016-11-08 12:31:28]

On 2016/11/08 12:29:16, jgruber wrote:
> On 2016/11/08 11:32:24, Yang wrote:
> > Please take a look. Popping context before return confuses the debugger .
> 
> We will need to clean up the directory structure in test/debugger at some
point.
> For instance, right now we have t/d/debug/regress and t/d/regress.

You are right. Does it make sense to have a t/d/debug? What other subdirectories
in t/d/ do you have in mind?

[commit-bot: I haz the power, 2016-11-17 22:25:50]

Description was changed from

==========
[debugger] do not accidentally pop contexts in bytecode

R=jgruber@chromium.org, mstarzinger@chromium.org
BUG=v8:5610
==========

to

==========
[debugger] do not accidentally pop contexts in bytecode

R=jgruber@chromium.org, mstarzinger@chromium.org
BUG=v8:5610

Committed: https://crrev.com/a168eb15bc2f5d9d78c631cbe66fdfa914e484b7
Cr-Commit-Position: refs/heads/master@{#40827}
==========

[commit-bot: I haz the power, 2016-11-17 22:25:51]

Patchset 2 (id:??) landed as
https://crrev.com/a168eb15bc2f5d9d78c631cbe66fdfa914e484b7
Cr-Commit-Position: refs/heads/master@{#40827}