Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: google_apis/gcm/engine/registration_request.cc

Issue 248213004: Record connection, registration, and receiving activities. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/engine/registration_request.cc
diff --git a/google_apis/gcm/engine/registration_request.cc b/google_apis/gcm/engine/registration_request.cc
index db6981d231eed3a6d2e65df3f11a8230408ec7b1..13a040b30ed7bc3ee2b8dc2346b6601c6e6e43be 100644
--- a/google_apis/gcm/engine/registration_request.cc
+++ b/google_apis/gcm/engine/registration_request.cc
@@ -9,6 +9,7 @@
#include "base/metrics/histogram.h"
#include "base/strings/string_number_conversions.h"
#include "base/values.h"
+#include "google_apis/gcm/monitoring/gcm_stats_recorder.h"
#include "net/base/escape.h"
#include "net/http/http_request_headers.h"
#include "net/http/http_status_code.h"
@@ -102,12 +103,14 @@ RegistrationRequest::RegistrationRequest(
const net::BackoffEntry::Policy& backoff_policy,
const RegistrationCallback& callback,
int max_retry_count,
- scoped_refptr<net::URLRequestContextGetter> request_context_getter)
+ scoped_refptr<net::URLRequestContextGetter> request_context_getter,
+ GCMStatsRecorder* recorder)
: callback_(callback),
request_info_(request_info),
backoff_entry_(&backoff_policy),
request_context_getter_(request_context_getter),
retries_left_(max_retry_count),
+ recorder_(recorder),
weak_ptr_factory_(this) {
DCHECK_GE(max_retry_count, 0);
}
@@ -152,6 +155,7 @@ void RegistrationRequest::Start() {
DVLOG(1) << "Performing registration for: " << request_info_.app_id;
DVLOG(1) << "Registration request: " << body;
url_fetcher_->SetUploadData(kRegistrationRequestContentType, body);
+ recorder_->RecordRegistrationSent(request_info_.app_id, senders);
url_fetcher_->Start();
}
@@ -225,14 +229,26 @@ void RegistrationRequest::OnURLFetchComplete(const net::URLFetcher* source) {
std::string token;
Status status = ParseResponse(source, &token);
RecordRegistrationStatusToUMA(status);
+ recorder_->RecordRegistrationResponse(
+ request_info_.app_id,
+ request_info_.sender_ids,
+ status);
if (ShouldRetryWithStatus(status)) {
if (retries_left_ > 0) {
+ recorder_->RecordRegistrationRetryRequested(
+ request_info_.app_id,
+ request_info_.sender_ids,
+ retries_left_);
RetryWithBackoff(true);
return;
}
status = REACHED_MAX_RETRIES;
+ recorder_->RecordRegistrationResponse(
+ request_info_.app_id,
+ request_info_.sender_ids,
+ status);
RecordRegistrationStatusToUMA(status);
}
« no previous file with comments | « google_apis/gcm/engine/registration_request.h ('k') | google_apis/gcm/engine/registration_request_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698