Fix DM race in SVGSrc

Fix DM race in SVGSrc

The SVG source currently attempts to build the DOM lazily, in response
to draw() or size() calls.  But apprently DM may call these
concurrently.

Build the DOM in the constructor instead, to avoid races (and the need
for synchronization).

R=robertphillips@google.com,mtklein@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2482123003

Committed: https://skia.googlesource.com/skia/+/acd2f5cddc631d5008a04da483d630968df307c9

[f(malita), 2016-11-08 14:39:24]

Description was changed from

==========
Fix race in the SVG DMSrc

The SVG source currently attempts to build the DOM lazily, in response
to draw() or size() calls.  But apprently DM may call these
concurrently.

Build the DOM in the constructor instead, to avoid races (and the need
for synchronization).

R=robertphillips@google.com,mtklein@google.com
==========

to

==========
Fix race in the SVG DMSrc

The SVG source currently attempts to build the DOM lazily, in response
to draw() or size() calls.  But apprently DM may call these
concurrently.

Build the DOM in the constructor instead, to avoid races (and the need
for synchronization).

R=robertphillips@google.com,mtklein@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2482123003
==========

[f(malita), 2016-11-08 14:42:10]

Alternatively, we could add a mutex and synchronize ensureDOM().  But I don't
think lazy parsing is worth the trouble, so let's go with front-loading for now.

[f(malita), 2016-11-08 14:42:15]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 14:42:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-11-08 14:42:54]

Description was changed from

==========
Fix race in the SVG DMSrc

The SVG source currently attempts to build the DOM lazily, in response
to draw() or size() calls.  But apprently DM may call these
concurrently.

Build the DOM in the constructor instead, to avoid races (and the need
for synchronization).

R=robertphillips@google.com,mtklein@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2482123003
==========

to

==========
Fix DM race in SVGSrc

The SVG source currently attempts to build the DOM lazily, in response
to draw() or size() calls.  But apprently DM may call these
concurrently.

Build the DOM in the constructor instead, to avoid races (and the need
for synchronization).

R=robertphillips@google.com,mtklein@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2482123003
==========

[f(malita), 2016-11-08 14:44:33]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 14:44:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-11-08 14:51:08]

lgtm

[commit-bot: I haz the power, 2016-11-08 15:12:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 15:12:07]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-11-08 15:12:37]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2016-11-08 15:12:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 15:13:47]

Description was changed from

==========
Fix DM race in SVGSrc

The SVG source currently attempts to build the DOM lazily, in response
to draw() or size() calls.  But apprently DM may call these
concurrently.

Build the DOM in the constructor instead, to avoid races (and the need
for synchronization).

R=robertphillips@google.com,mtklein@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2482123003
==========

to

==========
Fix DM race in SVGSrc

The SVG source currently attempts to build the DOM lazily, in response
to draw() or size() calls.  But apprently DM may call these
concurrently.

Build the DOM in the constructor instead, to avoid races (and the need
for synchronization).

R=robertphillips@google.com,mtklein@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2482123003

Committed:
https://skia.googlesource.com/skia/+/acd2f5cddc631d5008a04da483d630968df307c9
==========

[commit-bot: I haz the power, 2016-11-08 15:13:48]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/acd2f5cddc631d5008a04da483d630968df307c9

[mtklein_C, 2016-11-08 15:42:37]

mtklein@chromium.org changed reviewers:
+ mtklein@chromium.org

[mtklein_C, 2016-11-08 15:42:37]

Right, DM uses Srcs concurrently when possible unless they override serial() to
return true, in which case they're used only on the main thread.

[mtklein_C, 2016-11-08 15:43:36]

Is it safe to revert https://skia-review.googlesource.com/c/4526/ now?

[f(malita), 2016-11-08 16:10:08]

On 2016/11/08 15:43:36, mtklein_C wrote:
> Is it safe to revert https://skia-review.googlesource.com/c/4526/ now?

Should be safe.  I just reverted, let's see.