Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Unified Diff: pydir/build-runtime.py

Issue 2482123002: Subzero, MIPS32: Sandbox initial patch (Closed)
Patch Set: Minor addition, formatting Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/IceTargetLoweringMIPS32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pydir/build-runtime.py
diff --git a/pydir/build-runtime.py b/pydir/build-runtime.py
index 622235bbf65e5bc13aa332fea6356a7eaedd2852..a351fd6865f26e1408694da3be01c3ecbe8c4ba1 100755
--- a/pydir/build-runtime.py
+++ b/pydir/build-runtime.py
@@ -15,7 +15,7 @@ def Translate(ll_files, extra_args, obj, verbose, target):
Use pnacl-llc to translate textual bitcode input ll_files into object file
obj, using extra_args as the architectural flags.
"""
- externalize = [] if target == 'mips32' else ['-externalize']
+ externalize = ['-externalize']
shellcmd(['cat'] + ll_files + ['|',
'pnacl-llc',
'-function-sections',
@@ -24,10 +24,10 @@ def Translate(ll_files, extra_args, obj, verbose, target):
'-bitcode-format=llvm',
'-o', obj
] + extra_args + externalize, echo=verbose)
- strip_syms = [] if target == 'mips32' else ['nacl_tp_tdb_offset',
- 'nacl_tp_tls_offset']
+ localize_syms = ['nacl_tp_tdb_offset', 'nacl_tp_tls_offset']
+
shellcmd([GetObjcopyCmd(target), obj] +
- [('--strip-symbol=' + sym) for sym in strip_syms])
+ [('--localize-symbol=' + sym) for sym in localize_syms])
def PartialLink(obj_files, extra_args, lib, verbose):
« no previous file with comments | « no previous file | src/IceTargetLoweringMIPS32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698