third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js - Issue 2482073002: DevTools: introduce beautiful checkmarks in navigator and editor tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

Issue 2482073002: DevTools: introduce beautiful checkmarks in navigator and editor tabs (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css » ('j') | third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js b/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

index c133440af4af57d22c9a1e2886ca283f4d8ad595..da78e883038f485e52a467e7fe6234cdf8df030a 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

@@ -552,11 +552,14 @@ WebInspector.TabbedEditorContainer = class extends WebInspector.Object {

if (tabId) {

var title = this._titleForFile(uiSourceCode);

this._tabbedPane.changeTabTitle(tabId, title);

- if (WebInspector.persistence.hasUnsavedCommittedChanges(uiSourceCode))

+ if (WebInspector.persistence.hasUnsavedCommittedChanges(uiSourceCode)) {

this._tabbedPane.setTabIcon(

tabId, 'smallicon-warning', WebInspector.UIString('Changes to this file were not saved to file system.'));

- else

+ } else if (Runtime.experiments.isEnabled('persistence2') && WebInspector.persistence.binding(uiSourceCode)) {

+ this._tabbedPane.setTabIcon(tabId, 'smallicon-checkmark');

dgozman 2016/11/08 20:52:29 Let's have a tooltip explaining this checkmark (si

lushnikov 2016/11/09 19:30:19 Done.

+ } else {

this._tabbedPane.setTabIcon(tabId, '');

+ }

}