Remove a DCHECK in GpuChannelMessageFilter

Remove a DCHECK in GpuChannelMessageFilter

GpuChannelMessageFilter::OnFilterRemoved asserts |channel_| is non null.
This is no longer true after r430159 or 0e85f1d17a35bbe7, since in new code,
ChannelProxy calls MessageFilter::OnFilterRemoved even when the channel
is closed while the filter registration is pending.

This CL just removes the assertion, since null |channel_| should be harmless
here.

BUG=662693, 662688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/8826eda8787c97736f2b671a2548dbcafd0b89aa
Cr-Commit-Position: refs/heads/master@{#430862}

[tzik, 2016-11-08 05:13:02]

Description was changed from

==========
Remove a DCHECK in GpuChannelMessageFilter

GpuChannelMessageFilter::OnFilterRemoved asserts |channel_| is non null.
This is no longer true after r430159 or 0e85f1d17a35bbe7, since in new code,
ChannelProxy calls MessageFilter::OnFilterRemoved even when the channel
is closed while the filter registration is pending.

This CL just removes the assertion, since null |channel_| should be harmless
here.

BUG=662693
==========

to

==========
Remove a DCHECK in GpuChannelMessageFilter

GpuChannelMessageFilter::OnFilterRemoved asserts |channel_| is non null.
This is no longer true after r430159 or 0e85f1d17a35bbe7, since in new code,
ChannelProxy calls MessageFilter::OnFilterRemoved even when the channel
is closed while the filter registration is pending.

This CL just removes the assertion, since null |channel_| should be harmless
here.

BUG=662693
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tzik, 2016-11-08 05:16:49]

Description was changed from

==========
Remove a DCHECK in GpuChannelMessageFilter

GpuChannelMessageFilter::OnFilterRemoved asserts |channel_| is non null.
This is no longer true after r430159 or 0e85f1d17a35bbe7, since in new code,
ChannelProxy calls MessageFilter::OnFilterRemoved even when the channel
is closed while the filter registration is pending.

This CL just removes the assertion, since null |channel_| should be harmless
here.

BUG=662693
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove a DCHECK in GpuChannelMessageFilter

GpuChannelMessageFilter::OnFilterRemoved asserts |channel_| is non null.
This is no longer true after r430159 or 0e85f1d17a35bbe7, since in new code,
ChannelProxy calls MessageFilter::OnFilterRemoved even when the channel
is closed while the filter registration is pending.

This CL just removes the assertion, since null |channel_| should be harmless
here.

BUG=662693
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tzik, 2016-11-08 05:16:49]

tzik@chromium.org changed reviewers:
+ jbauman@chromium.org, pastarmovj@chromium.org

[tzik, 2016-11-08 05:17:09]

PTAL

[tzik, 2016-11-08 06:32:33]

Description was changed from

==========
Remove a DCHECK in GpuChannelMessageFilter

GpuChannelMessageFilter::OnFilterRemoved asserts |channel_| is non null.
This is no longer true after r430159 or 0e85f1d17a35bbe7, since in new code,
ChannelProxy calls MessageFilter::OnFilterRemoved even when the channel
is closed while the filter registration is pending.

This CL just removes the assertion, since null |channel_| should be harmless
here.

BUG=662693
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove a DCHECK in GpuChannelMessageFilter

GpuChannelMessageFilter::OnFilterRemoved asserts |channel_| is non null.
This is no longer true after r430159 or 0e85f1d17a35bbe7, since in new code,
ChannelProxy calls MessageFilter::OnFilterRemoved even when the channel
is closed while the filter registration is pending.

This CL just removes the assertion, since null |channel_| should be harmless
here.

BUG=662693,662688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tzik, 2016-11-08 06:36:12]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 06:36:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-11-08 06:36:41]

tzik@chromium.org changed reviewers:
+ boliu@chromium.org

[tzik, 2016-11-08 06:36:42]

+boliu as //android_webview owner.

[commit-bot: I haz the power, 2016-11-08 07:50:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 07:50:05]

Dry run: This issue passed the CQ dry run.

[pastarmovj, 2016-11-08 09:24:38]

**/policy lgtm.

[boliu, 2016-11-08 14:32:48]

a_w lgtm

fwiw, I don't agree with the fix, but I'll let gpu owner decide:
https://codereview.chromium.org/2469123003/#msg29

[jbauman, 2016-11-08 22:29:12]

On 2016/11/08 14:32:48, boliu wrote:
> a_w lgtm
> 
> fwiw, I don't agree with the fix, but I'll let gpu owner decide:
> https://codereview.chromium.org/2469123003/#msg29

lgtm, this seems ok for our purposes.

[tzik, 2016-11-09 04:14:30]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2016-11-09 04:14:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 04:31:02]

Description was changed from

==========
Remove a DCHECK in GpuChannelMessageFilter

GpuChannelMessageFilter::OnFilterRemoved asserts |channel_| is non null.
This is no longer true after r430159 or 0e85f1d17a35bbe7, since in new code,
ChannelProxy calls MessageFilter::OnFilterRemoved even when the channel
is closed while the filter registration is pending.

This CL just removes the assertion, since null |channel_| should be harmless
here.

BUG=662693,662688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove a DCHECK in GpuChannelMessageFilter

GpuChannelMessageFilter::OnFilterRemoved asserts |channel_| is non null.
This is no longer true after r430159 or 0e85f1d17a35bbe7, since in new code,
ChannelProxy calls MessageFilter::OnFilterRemoved even when the channel
is closed while the filter registration is pending.

This CL just removes the assertion, since null |channel_| should be harmless
here.

BUG=662693,662688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-09 04:31:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-09 04:33:03]

Description was changed from

==========
Remove a DCHECK in GpuChannelMessageFilter

GpuChannelMessageFilter::OnFilterRemoved asserts |channel_| is non null.
This is no longer true after r430159 or 0e85f1d17a35bbe7, since in new code,
ChannelProxy calls MessageFilter::OnFilterRemoved even when the channel
is closed while the filter registration is pending.

This CL just removes the assertion, since null |channel_| should be harmless
here.

BUG=662693,662688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove a DCHECK in GpuChannelMessageFilter

GpuChannelMessageFilter::OnFilterRemoved asserts |channel_| is non null.
This is no longer true after r430159 or 0e85f1d17a35bbe7, since in new code,
ChannelProxy calls MessageFilter::OnFilterRemoved even when the channel
is closed while the filter registration is pending.

This CL just removes the assertion, since null |channel_| should be harmless
here.

BUG=662693,662688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/8826eda8787c97736f2b671a2548dbcafd0b89aa
Cr-Commit-Position: refs/heads/master@{#430862}
==========

[commit-bot: I haz the power, 2016-11-09 04:33:04]

Patchset 2 (id:??) landed as
https://crrev.com/8826eda8787c97736f2b671a2548dbcafd0b89aa
Cr-Commit-Position: refs/heads/master@{#430862}