[ash-md] Updated layout of Brightness and Audio system menu rows to the material design spec.

ash/common/system/tray/tray_constants.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/tray/tray_constants.h"
 
 #include "ash/common/material_design/material_design_controller.h"
 #include "base/logging.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/gfx/color_palette.h"
@@ skipping 87 matching lines @@
 const float kTrayPopupInkDropHighlightOpacity = 0.08f;
 const int kTrayPopupInkDropInset = 4;
 
 int GetTrayConstant(TrayConstant constant) {
   const int kTrayItemHeightLegacy[] = {38, kTrayItemSize, kTrayItemSize};
   const int kTraySpacing[] = {4, 0, 0};
   const int kTrayPaddingFromEdgeOfShelf[] = {3, 4, 4};
   const int kTrayPopupItemHeight[] = {46, 48, 48};
   // FixedSizedImageViews use the contained ImageView's width for 0 values.
   const int kTrayPopupItemMainImageRegionWidth[] = {0, 48, 48};
-  // FixedSizedImageViews use the contained ImageView's width for 0 values.
-  const int kTrayPopupItemMoreImageRegionWidth[] = {0, 20, 20};
-  const int kTrayPopupItemLeftInset[] = {0, 0, 4};
+  const int kTrayPopupItemMoreImageSize[] = {25, 20, 20};

[tdanderson, 2016/11/09 01:38:33]

Consider using kMenuIconSize in place of the literal '20's here.

[bruthig, 2016/11/10 02:54:54]

Done.

+  const int kTrayPopupItemMoreRegionHorizontalInset[] = {10, 10, 10};
+  const int kTrayPopupItemLeftInset[] = {0, 4, 4};

[tdanderson, 2016/11/09 01:38:33]

Good catch

   const int kTrayPopupItemRightInset[] = {0, 0, 0};
   const int kTrayPopupItemMinStartWidth[] = {46, 48, 48};
   const int kTrayPopupItemMinEndWidth[] = {40, 40, 40};
   const int kVirtualKeyboardButtonSize[] = {39, kTrayItemSize, kTrayItemSize};
   const int kTrayImeMenuIcon[] = {40, kTrayItemSize, kTrayItemSize};
   const int kTrayImageItemPadding[] = {1, 3, 3};
 
   const int mode = MaterialDesignController::GetMode();
   DCHECK(mode >= MaterialDesignController::NON_MATERIAL &&
          mode <= MaterialDesignController::MATERIAL_EXPERIMENTAL);
 
   switch (constant) {
     case TRAY_ITEM_HEIGHT_LEGACY:
       return kTrayItemHeightLegacy[mode];
     case TRAY_SPACING:
       return kTraySpacing[mode];
     case TRAY_PADDING_FROM_EDGE_OF_SHELF:
       return kTrayPaddingFromEdgeOfShelf[mode];
     case TRAY_POPUP_ITEM_HEIGHT:
       return kTrayPopupItemHeight[mode];
     case TRAY_POPUP_ITEM_MAIN_IMAGE_CONTAINER_WIDTH:
       return kTrayPopupItemMainImageRegionWidth[mode];
-    case TRAY_POPUP_ITEM_MORE_IMAGE_CONTAINER_WIDTH:
-      return kTrayPopupItemMoreImageRegionWidth[mode];
+    case TRAY_POPUP_ITEM_MORE_IMAGE_SIZE:
+      return kTrayPopupItemMoreImageSize[mode];
+    case TRAY_POPUP_ITEM_MORE_REGION_HORIZONTAL_INSET:
+      return kTrayPopupItemMoreRegionHorizontalInset[mode];
     case TRAY_POPUP_ITEM_LEFT_INSET:
       return kTrayPopupItemLeftInset[mode];
     case TRAY_POPUP_ITEM_RIGHT_INSET:
       return kTrayPopupItemRightInset[mode];
     case TRAY_POPUP_ITEM_MIN_START_WIDTH:
       return kTrayPopupItemMinStartWidth[mode];
     case TRAY_POPUP_ITEM_MIN_END_WIDTH:
       return kTrayPopupItemMinEndWidth[mode];
     case VIRTUAL_KEYBOARD_BUTTON_SIZE:
       return kVirtualKeyboardButtonSize[mode];
     case TRAY_IME_MENU_ICON:
       return kTrayImeMenuIcon[mode];
     case TRAY_IMAGE_ITEM_PADDING:
       return kTrayImageItemPadding[mode];
   }
   NOTREACHED();
   return 0;
 }
 
 }  // namespace ash