chrome/app/generated_resources.grd - Issue 2482023002: Put a Settings link on the new Google Search geolocation disclosure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/generated_resources.grd

Issue 2482023002: Put a Settings link on the new Google Search geolocation disclosure. (Closed)

Patch Set: Update comment Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBar.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBar.java ('k') | chrome/browser/android/search_geolocation_disclosure_infobar_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index a778a54350cd1f968f99be784251fa0ab81ec3da..a17e653fbf6ec70b399cfa2538376c0cfb6ccde0 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -15597,8 +15597,11 @@ read aloud to screenreader users to announce that a completion is available.">

Have consistent geolocation access between the omnibox and default search engine.

</message>

- <message name="IDS_SEARCH_GEOLOCATION_DISCLOSURE_INFOBAR_TEXT" desc="Text to put in the infobar disclosing Google Search's usage of location">

- Google Search uses your location to show local search results. You can change this in Settings.

+ <message name="IDS_SEARCH_GEOLOCATION_DISCLOSURE_INFOBAR_TEXT" desc="Text to put in the infobar disclosing Google Search's usage of location. The message contains a link to a settings page. The link text is a separate string in the translation console and appears here as a placeholder text.">

+ Google Search uses your location to show local search results. You can change this in <ph name="SETTINGS_LINK">$1<ex>Link to Settings page</ex></ph>.

+ </message>

+ <message name="IDS_SEARCH_GEOLOCATION_DISCLOSURE_INFOBAR_SETTINGS_LINK_TEXT" desc="Text to put in the link to the Settings page in the search geolocation disclosure UI.">

gone 2016/11/08 04:40:28 It'd be good to just reuse the actual Settings tit

benwells 2016/11/08 11:26:34 IDS_PREFERENCES is "Preferences", and "IDS_SETTING

+ Settings

</message>

</if>