Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2481963002: IPC: Relax thread constraints on Channel-associated send (Closed)

Created:
4 years, 1 month ago by Ken Rockot(use gerrit already)
Modified:
4 years, 1 month ago
Reviewers:
yzshen1
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IPC: Relax thread constraints on Channel-associated send This removes a DCHECK from ChannelAssociatedGroupController, allowing messages to be sent from arbitrary threads rather than only from the IO thread or proxy thread. While it is still unsafe to bind associated endpoints on non-proxy non-IO threads, this allows control messages to be transmitted safely from any thread, so for example an AssociatedPtrInfo can safely notify the request side of closure if it's destroyed on an arbitrary thread. BUG=663046 R=yzshen@chromium.org Committed: https://crrev.com/becd3f741efe619c34bb569fd4ab18d85da45d6f Cr-Commit-Position: refs/heads/master@{#430705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M ipc/ipc_mojo_bootstrap.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Ken Rockot(use gerrit already)
PTAL. See the bug for context. If someone accidentally uses a Channel-associated AssociatedInterfacePtr from an ...
4 years, 1 month ago (2016-11-07 23:07:30 UTC) #3
yzshen1
lgtm
4 years, 1 month ago (2016-11-07 23:25:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481963002/1
4 years, 1 month ago (2016-11-07 23:30:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg/builds/28376)
4 years, 1 month ago (2016-11-08 01:10:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481963002/1
4 years, 1 month ago (2016-11-08 20:42:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 20:47:38 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 21:00:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/becd3f741efe619c34bb569fd4ab18d85da45d6f
Cr-Commit-Position: refs/heads/master@{#430705}

Powered by Google App Engine
This is Rietveld 408576698