storage/browser/fileapi/file_system_url_request_job.cc - Issue 2481923002: [WIP] make GURL::path() return a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/browser/fileapi/file_system_url_request_job.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)

Patch Set: thanks asan Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: storage/browser/fileapi/file_system_url_request_job.cc

diff --git a/storage/browser/fileapi/file_system_url_request_job.cc b/storage/browser/fileapi/file_system_url_request_job.cc

index 30fb47d2589f898a18d2053c334a552d805e3ff7..42d7c96e779354a28964bd2443acb4dd559d13d0 100644

--- a/storage/browser/fileapi/file_system_url_request_job.cc

+++ b/storage/browser/fileapi/file_system_url_request_job.cc

@@ -244,7 +244,7 @@ bool FileSystemURLRequestJob::IsRedirectResponse(GURL* location,

if (is_directory_) {

// This happens when we discovered the file is a directory, so needs a

// slash at the end of the path.

- std::string new_path = request_->url().path();

+ std::string new_path = request_->url().path().as_string();

new_path.push_back('/');

GURL::Replacements replacements;

replacements.SetPathStr(new_path);