Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: net/url_request/sdch_dictionary_fetcher_unittest.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)
Patch Set: thanks asan Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_simple_server_session.cc ('k') | net/url_request/url_request_file_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/sdch_dictionary_fetcher_unittest.cc
diff --git a/net/url_request/sdch_dictionary_fetcher_unittest.cc b/net/url_request/sdch_dictionary_fetcher_unittest.cc
index 2b1f2d36e11276cf43b8e9ac35d9cc02ec39ea36..1aec0c59945381b6c8cbfa8ecc9832d3cf71bd31 100644
--- a/net/url_request/sdch_dictionary_fetcher_unittest.cc
+++ b/net/url_request/sdch_dictionary_fetcher_unittest.cc
@@ -168,10 +168,11 @@ class SDCHTestRequestInterceptor : public URLRequestInterceptor {
NetworkDelegate* network_delegate) const override {
lifecycle_callback_.Run(1, 0);
- std::string path = request->url().path();
+ base::StringPiece path = request->url().path();
if (base::StartsWith(path, kRedirectPath, base::CompareCase::SENSITIVE)) {
return new TestURLRequestRedirectJob(
- request, network_delegate, GURL(path.substr(strlen(kRedirectPath))),
+ request, network_delegate,
+ GURL(path.substr(strlen(kRedirectPath)).as_string()),
URLRequestRedirectJob::REDIRECT_307_TEMPORARY_REDIRECT, "testing",
base::Bind(lifecycle_callback_, -1, 0));
}
« no previous file with comments | « net/tools/quic/quic_simple_server_session.cc ('k') | net/url_request/url_request_file_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698