net/tools/quic/quic_in_memory_cache_test.cc - Issue 2481923002: [WIP] make GURL::path() return a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_in_memory_cache_test.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)

Patch Set: thanks asan Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/tools/quic/quic_in_memory_cache_test.cc

diff --git a/net/tools/quic/quic_in_memory_cache_test.cc b/net/tools/quic/quic_in_memory_cache_test.cc

index 249f6618f98abd91e5d71c1518512881273adad8..f3dab9baad5dd276da2fb37f58cf81697ab2d308 100644

--- a/net/tools/quic/quic_in_memory_cache_test.cc

+++ b/net/tools/quic/quic_in_memory_cache_test.cc

@@ -245,7 +245,7 @@ TEST_F(QuicInMemoryCacheTest, GetServerPushResourcesAndPushResponses) {

for (const auto& push_resource : push_resources) {

GURL url = resources.front().request_url;

string host = url.host();

- string path = url.path();

+ string path = url.path().as_string();

const QuicInMemoryCache::Response* response =

cache->GetResponse(host, path);

ASSERT_TRUE(response);

« no previous file with comments | « net/tools/quic/quic_in_memory_cache.cc ('k') | net/tools/quic/quic_simple_server_session.cc » ('j') | no next file with comments »