ios/web/webui/crw_web_ui_manager_unittest.mm - Issue 2481923002: [WIP] make GURL::path() return a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/webui/crw_web_ui_manager_unittest.mm

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)

Patch Set: thanks asan Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/webui/crw_web_ui_manager_unittest.mm

diff --git a/ios/web/webui/crw_web_ui_manager_unittest.mm b/ios/web/webui/crw_web_ui_manager_unittest.mm

index e5274d8541690757deffc152748c6c726ce37d40..b040edc9ae4b92b94a652358da02da40e5e91f9e 100644

--- a/ios/web/webui/crw_web_ui_manager_unittest.mm

+++ b/ios/web/webui/crw_web_ui_manager_unittest.mm

@@ -79,7 +79,7 @@ class MockURLFetcherBlockAdapter : public URLFetcherBlockAdapter {

NSData* favicon = [NSData

dataWithContentsOfFile:base::SysUTF8ToNSString(favicon_path.value())];

completion_handler_.get()(favicon, this);

- } else if (url_.path().find(kMojoModuleName) != std::string::npos) {

+ } else if (url_.path().find(kMojoModuleName) != base::StringPiece::npos) {

completion_handler_.get()(

[kMojoModule dataUsingEncoding:NSUTF8StringEncoding], this);