ios/net/cookies/cookie_store_ios_unittest.mm - Issue 2481923002: [WIP] make GURL::path() return a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/net/cookies/cookie_store_ios_unittest.mm

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)

Patch Set: thanks asan Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/net/cookies/cookie_store_ios_unittest.mm

diff --git a/ios/net/cookies/cookie_store_ios_unittest.mm b/ios/net/cookies/cookie_store_ios_unittest.mm

index 87c7bd4e9b0c00f359566630b2112e7c5ca9541b..fc2b34b1c9c5655382c97db71123d884152fcdcc 100644

--- a/ios/net/cookies/cookie_store_ios_unittest.mm

+++ b/ios/net/cookies/cookie_store_ios_unittest.mm

@@ -405,7 +405,7 @@ class CookieStoreIOSWithBackend : public testing::Test {

NSHTTPCookieStorage* storage =

[NSHTTPCookieStorage sharedHTTPCookieStorage];

[storage setCookie:[NSHTTPCookie cookieWithProperties:@{

- NSHTTPCookiePath : base::SysUTF8ToNSString(url.path()),

+ NSHTTPCookiePath : base::SysUTF8ToNSString(url.path().as_string()),

NSHTTPCookieName : base::SysUTF8ToNSString(name),

NSHTTPCookieValue : base::SysUTF8ToNSString(value),

NSHTTPCookieDomain : base::SysUTF8ToNSString(url.host()),

« no previous file with comments | « ios/net/cookies/cookie_cache_unittest.cc ('k') | ios/web/public/test/http_server.mm » ('j') | no next file with comments »