extensions/common/url_pattern.cc - Issue 2481923002: [WIP] make GURL::path() return a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/url_pattern.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)

Patch Set: thanks asan Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/url_pattern.cc

diff --git a/extensions/common/url_pattern.cc b/extensions/common/url_pattern.cc

index 81edf7f55b09e6a74ba9fc4911421ecf3e9733de..4fd1661b7c2d428a10f750f9cc4f953b8459857c 100644

--- a/extensions/common/url_pattern.cc

+++ b/extensions/common/url_pattern.cc

@@ -370,7 +370,7 @@ bool URLPattern::MatchesURL(const GURL& test) const {

std::string path_for_request = test.PathForRequest();

if (has_inner_url)

- path_for_request = test_url->path() + path_for_request;

+ path_for_request = test_url->path().as_string() + path_for_request;

return MatchesSecurityOriginHelper(*test_url) &&

MatchesPath(path_for_request);

« no previous file with comments | « extensions/common/file_util.cc ('k') | extensions/renderer/script_context.cc » ('j') | no next file with comments »