content/shell/browser/layout_test/layout_test_browser_context.cc - Issue 2481923002: [WIP] make GURL::path() return a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_browser_context.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)

Patch Set: thanks asan Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/browser/layout_test/layout_test_browser_context.cc

diff --git a/content/shell/browser/layout_test/layout_test_browser_context.cc b/content/shell/browser/layout_test/layout_test_browser_context.cc

index e5adfbfba5968088cab3f767ce63dff18d45d5b4..b1ec40fed851e0d9a0c379e6ec6b5bcb7af2f189 100644

--- a/content/shell/browser/layout_test/layout_test_browser_context.cc

+++ b/content/shell/browser/layout_test/layout_test_browser_context.cc

@@ -67,7 +67,8 @@ class MojomProtocolHandler : public net::URLRequestJobFactory::ProtocolHandler {

prefix = prefix.AppendASCII("gen");

- base::FilePath path = prefix.AppendASCII(url.path().substr(2) + ".js");

+ base::FilePath path =

+ prefix.AppendASCII(url.path().substr(2).as_string() + ".js");

if (path.ReferencesParent())

return nullptr;