content/browser/webui/url_data_manager_backend.cc - Issue 2481923002: [WIP] make GURL::path() return a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/webui/url_data_manager_backend.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)

Patch Set: thanks asan Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/webui/url_data_manager_backend.cc

diff --git a/content/browser/webui/url_data_manager_backend.cc b/content/browser/webui/url_data_manager_backend.cc

index 808678fd44192b121667774798a3f661acc72d83..35c8e846906e10a6f0f15dc7442bf63e7951463c 100644

--- a/content/browser/webui/url_data_manager_backend.cc

+++ b/content/browser/webui/url_data_manager_backend.cc

@@ -569,7 +569,7 @@ class ChromeProtocolHandler

request->url().host_piece() == kChromeUINetworkErrorHost) {

// Get the error code passed in via the request URL path.

std::basic_string<char> error_code_string =

- request->url().path().substr(1);

+ request->url().path().substr(1).as_string();

int error_code;

if (base::StringToInt(error_code_string, &error_code)) {