Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)
Patch Set: thanks asan Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index 60d70167be0bf719f8c6fa3c92d39f5129f5671a..8af8bcaeef7bf40213963b0cf8646e9d37d1c568 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -1369,7 +1369,7 @@ void ServiceWorkerVersion::OnRegisterForeignFetchScopes(
// Renderer should have already verified all these urls are inside the
// worker's scope, but verify again here on the browser process side.
GURL origin = scope_.GetOrigin();
- std::string scope_path = scope_.path();
+ base::StringPiece scope_path = scope_.path();
for (const GURL& url : sub_scopes) {
if (!url.is_valid() || url.GetOrigin() != origin ||
!base::StartsWith(url.path(), scope_path,

Powered by Google App Engine
This is Rietveld 408576698