components/history/core/browser/web_history_service.cc - Issue 2481923002: [WIP] make GURL::path() return a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/web_history_service.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)

Patch Set: thanks asan Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/web_history_service.cc

diff --git a/components/history/core/browser/web_history_service.cc b/components/history/core/browser/web_history_service.cc

index abe202c87cdbc5dddefc9b56086533918efb5802..747553c135f225b862cf734150b9bc2e7e08fc39 100644

--- a/components/history/core/browser/web_history_service.cc

+++ b/components/history/core/browser/web_history_service.cc

@@ -514,7 +514,7 @@ void WebHistoryService::QueryOtherFormsOfBrowsingHistory(

channel);

GURL::Replacements replace_path;

std::string new_path =

- url.path() + kQueryOtherFormsOfBrowsingHistoryUrlSuffix;

+ url.path().as_string() + kQueryOtherFormsOfBrowsingHistoryUrlSuffix;

replace_path.SetPathStr(new_path);

url = url.ReplaceComponents(replace_path);

DCHECK(url.is_valid());