chrome/renderer/app_categorizer.cc - Issue 2481923002: [WIP] make GURL::path() return a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/app_categorizer.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)

Patch Set: thanks asan Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/app_categorizer.cc

diff --git a/chrome/renderer/app_categorizer.cc b/chrome/renderer/app_categorizer.cc

index 42519779f555a46f96cbf139b90f19c3b105b78e..f42bed41b783f468a2fad79b8612d25396590a48 100644

--- a/chrome/renderer/app_categorizer.cc

+++ b/chrome/renderer/app_categorizer.cc

@@ -55,7 +55,7 @@ bool AppCategorizer::IsWhitelistedApp(

if (!app_url.SchemeIsCryptographic())

return false;

- std::string manifest_url_path = manifest_url.path();

+ base::StringPiece manifest_url_path = manifest_url.path();

bool is_photo_app =

manifest_url.SchemeIsCryptographic() &&

manifest_url.DomainIs("ssl.gstatic.com") &&