chrome/browser/web_applications/web_app.cc - Issue 2481923002: [WIP] make GURL::path() return a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_applications/web_app.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)

Patch Set: thanks asan Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/web_applications/web_app.cc

diff --git a/chrome/browser/web_applications/web_app.cc b/chrome/browser/web_applications/web_app.cc

index aa377066e0e75bbc252e94160916e94020041d37..2522e55fe1788a9ca09e7d6eb1ffa0f3641c3eab 100644

--- a/chrome/browser/web_applications/web_app.cc

+++ b/chrome/browser/web_applications/web_app.cc

@@ -390,7 +390,7 @@ std::string GenerateApplicationNameFromURL(const GURL& url) {

std::string t;

t.append(url.host());

t.append("_");

- t.append(url.path());

+ t.append(url.path().as_string());

return t;

}