chrome/browser/ui/webui/chromeos/login/screenlock_icon_source.cc - Issue 2481923002: [WIP] make GURL::path() return a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/screenlock_icon_source.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)

Patch Set: thanks asan Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/chromeos/login/screenlock_icon_source.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/screenlock_icon_source.cc b/chrome/browser/ui/webui/chromeos/login/screenlock_icon_source.cc

index bf07b1d5348b5a5679cce27a1a680d3876ae7c27..8b4d2dfdd2ce629c361e8dbaf538c4e7bb4b4e85 100644

--- a/chrome/browser/ui/webui/chromeos/login/screenlock_icon_source.cc

+++ b/chrome/browser/ui/webui/chromeos/login/screenlock_icon_source.cc

@@ -44,7 +44,7 @@ void ScreenlockIconSource::StartDataRequest(

GURL url(chrome::kChromeUIScreenlockIconURL + path);

std::string username = net::UnescapeURLComponent(

- url.path().substr(1),

+ url.path().as_string().substr(1),

net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS |

net::UnescapeRule::PATH_SEPARATORS | net::UnescapeRule::SPACES);