chrome/browser/extensions/webstore_inline_installer.cc - Issue 2481923002: [WIP] make GURL::path() return a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_inline_installer.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)

Patch Set: thanks asan Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_inline_installer.cc

diff --git a/chrome/browser/extensions/webstore_inline_installer.cc b/chrome/browser/extensions/webstore_inline_installer.cc

index 9e992bcb64fc1bedc00a3d598de8f3acc041de6b..c3022e725fc2f1b2381ec6c68a35bbd8e7f72995 100644

--- a/chrome/browser/extensions/webstore_inline_installer.cc

+++ b/chrome/browser/extensions/webstore_inline_installer.cc

@@ -229,7 +229,7 @@ bool WebstoreInlineInstaller::IsRequestorURLInVerifiedSite(

std::string port_spec =

verified_site_url.has_port() ? ":" + verified_site_url.port() : "";

- std::string path_spec = verified_site_url.path() + "*";

+ std::string path_spec = verified_site_url.path().as_string() + "*";

std::string verified_site_pattern_spec =

base::StringPrintf(

"%s://*.%s%s%s",