Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: chrome/browser/chromeos/login/saml/saml_browsertest.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)
Patch Set: thanks asan Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/saml/saml_browsertest.cc
diff --git a/chrome/browser/chromeos/login/saml/saml_browsertest.cc b/chrome/browser/chromeos/login/saml/saml_browsertest.cc
index 82b334db0af6424799c33880aef0f7842ba7e3dd..a5ddc56a63ad6e8943f1a383d061af8c29dab0fe 100644
--- a/chrome/browser/chromeos/login/saml/saml_browsertest.cc
+++ b/chrome/browser/chromeos/login/saml/saml_browsertest.cc
@@ -216,7 +216,7 @@ std::unique_ptr<HttpResponse> FakeSamlIdp::HandleRequest(
// The scheme and host of the URL is actually not important but required to
// get a valid GURL in order to parse |request.relative_url|.
GURL request_url = GURL("http://localhost").Resolve(request.relative_url);
- std::string request_path = request_url.path();
+ base::StringPiece request_path = request_url.path();
if (request_path == login_path_) {
std::string relay_state;
@@ -323,7 +323,7 @@ class SamlTest : public OobeBaseTest {
const GURL gaia_url = gaia_https_forwarder_.GetURLForSSLHost("");
const GURL saml_idp_url = saml_https_forwarder_.GetURLForSSLHost("SAML");
- fake_saml_idp_.SetUp(saml_idp_url.path(), gaia_url);
+ fake_saml_idp_.SetUp(saml_idp_url.path().as_string(), gaia_url);
fake_gaia_->RegisterSamlUser(kFirstSAMLUserEmail, saml_idp_url);
fake_gaia_->RegisterSamlUser(kSecondSAMLUserEmail, saml_idp_url);
fake_gaia_->RegisterSamlUser(
« no previous file with comments | « chrome/browser/chromeos/app_mode/fake_cws.cc ('k') | chrome/browser/chromeos/login/signin/oauth2_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698