[WIP] make GURL::path() return a StringPiece

extensions/browser/url_request_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/url_request_util.h"
 
 #include <string>
 
 #include "content/public/browser/resource_request_info.h"
 #include "content/public/common/browser_side_navigation_policy.h"
@@ skipping 10 matching lines @@
 namespace extensions {
 namespace url_request_util {
 
 bool AllowCrossRendererResourceLoad(net::URLRequest* request,
                                     bool is_incognito,
                                     const Extension* extension,
                                     InfoMap* extension_info_map,
                                     bool* allowed) {
   const content::ResourceRequestInfo* info =
       content::ResourceRequestInfo::ForRequest(request);
-  std::string resource_path = request->url().path();
+  base::StringPiece resource_path = request->url().path();
 
   // PlzNavigate: this logic is performed for main frame requests in
   // ExtensionNavigationThrottle::WillStartRequest.
   if (info->GetChildID() != -1 ||
       info->GetResourceType() != content::RESOURCE_TYPE_MAIN_FRAME ||
       !content::IsBrowserSideNavigationEnabled()) {
     // Extensions with webview: allow loading certain resources by guest
     // renderers with privileged partition IDs as specified in owner's extension
     // the manifest file.
     std::string owner_extension_id;
     int owner_process_id;
     WebViewRendererState::GetInstance()->GetOwnerInfo(
         info->GetChildID(), &owner_process_id, &owner_extension_id);
     const Extension* owner_extension =
         extension_info_map->extensions().GetByID(owner_extension_id);
     std::string partition_id;
     bool is_guest = WebViewRendererState::GetInstance()->GetPartitionID(
         info->GetChildID(), &partition_id);
 
     if (AllowCrossRendererResourceLoadHelper(
-            is_guest, extension, owner_extension, partition_id, resource_path,
-            info->GetPageTransition(), allowed)) {
+            is_guest, extension, owner_extension, partition_id,
+            resource_path.as_string(), info->GetPageTransition(), allowed)) {
       return true;
     }
   }
 
   // The following checks require that we have an actual extension object. If we
   // don't have it, allow the request handling to continue with the rest of the
   // checks.
   if (!extension) {
     *allowed = true;
     return true;
   }
 
   // Disallow loading of packaged resources for hosted apps. We don't allow
   // hybrid hosted/packaged apps. The one exception is access to icons, since
   // some extensions want to be able to do things like create their own
   // launchers.
   std::string resource_root_relative_path =
-      request->url().path().empty() ? std::string()
-                                    : request->url().path().substr(1);
+      request->url().path().empty()
+          ? std::string()
+          : request->url().path().substr(1).as_string();
   if (extension->is_hosted_app() &&
       !IconsInfo::GetIcons(extension)
            .ContainsPath(resource_root_relative_path)) {
     LOG(ERROR) << "Denying load of " << request->url().spec() << " from "
                << "hosted app.";
     *allowed = false;
     return true;
   }
 
   DCHECK_EQ(extension->url(), request->url().GetWithEmptyPath());
@@ skipping 13 matching lines @@
   } else if (info->GetResourceType() == content::RESOURCE_TYPE_SUB_FRAME) {
     // When navigating in subframe, allow if it is the same origin
     // as the top-level frame. This can only be the case if the subframe
     // request is coming from the extension process.
     if (extension_info_map->process_map().Contains(info->GetChildID())) {
       *allowed = true;
       return true;
     }
 
     // Also allow if the file is explicitly listed as a web_accessible_resource.
-    if (WebAccessibleResourcesInfo::IsResourceWebAccessible(extension,
-                                                            resource_path)) {
+    if (WebAccessibleResourcesInfo::IsResourceWebAccessible(
+            extension, resource_path.as_string())) {
       *allowed = true;
       return true;
     }
   }
 
   // Since not all subresources are required to be listed in a v2
   // manifest, we must allow all subresource loads if there are any web
   // accessible resources. See http://crbug.com/179127.
   if (!content::IsResourceTypeFrame(info->GetResourceType()) &&
       WebAccessibleResourcesInfo::HasWebAccessibleResources(extension)) {
@@ skipping 45 matching lines @@
   if (is_guest && !ui::PageTransitionIsWebTriggerable(page_transition)) {
     *allowed = false;
     return true;
   }
 
   return false;
 }
 
 }  // namespace url_request_util
 }  // namespace extensions