[WIP] make GURL::path() return a StringPiece

content/common/service_worker/service_worker_utils.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/service_worker/service_worker_utils.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/strings/string_util.h"
 #include "content/public/common/origin_util.h"
 
 namespace content {
 
 namespace {
 
 bool PathContainsDisallowedCharacter(const GURL& url) {
-  std::string path = url.path();
+  base::StringPiece path = url.path();
   DCHECK(base::IsStringUTF8(path));
 
   // We should avoid these escaped characters in the path component because
   // these can be handled differently depending on server implementation.
   if (path.find("%2f") != std::string::npos ||
       path.find("%2F") != std::string::npos) {
     return true;
   }
   if (path.find("%5c") != std::string::npos ||
       path.find("%5C") != std::string::npos) {
@@ skipping 28 matching lines @@
 
   std::string max_scope_string;
   if (service_worker_allowed_header_value) {
     GURL max_scope = script_url.Resolve(*service_worker_allowed_header_value);
     if (!max_scope.is_valid()) {
       *error_message = "An invalid Service-Worker-Allowed header value ('";
       error_message->append(*service_worker_allowed_header_value);
       error_message->append("') was received when fetching the script.");
       return false;
     }
-    max_scope_string = max_scope.path();
+    max_scope_string = max_scope.path().as_string();
   } else {
-    max_scope_string = script_url.Resolve(".").path();
+    max_scope_string = script_url.Resolve(".").path().as_string();
   }
 
-  std::string scope_string = scope.path();
+  base::StringPiece scope_string = scope.path();
   if (!base::StartsWith(scope_string, max_scope_string,
                         base::CompareCase::SENSITIVE)) {
     *error_message = "The path of the provided scope ('";
-    error_message->append(scope_string);
+    error_message->append(scope_string.as_string());
     error_message->append("') is not under the max scope allowed (");
     if (service_worker_allowed_header_value)
       error_message->append("set by Service-Worker-Allowed: ");
     error_message->append("'");
     error_message->append(max_scope_string);
     error_message->append(
         "'). Adjust the scope, move the Service Worker script, or use the "
         "Service-Worker-Allowed HTTP header to allow the scope.");
     return false;
   }
@@ skipping 54 matching lines @@
   if (!ServiceWorkerUtils::ScopeMatches(scope, url_))
     return false;
   if (match_.is_empty() || match_.spec().size() < scope.spec().size()) {
     match_ = scope;
     return true;
   }
   return false;
 }
 
 }  // namespace content