Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: chrome/renderer/extensions/webstore_bindings.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)
Patch Set: thanks asan Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/webstore_bindings.h" 5 #include "chrome/renderer/extensions/webstore_bindings.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 } 156 }
157 157
158 if (webstore_url.scheme() != webstore_base_url.scheme() || 158 if (webstore_url.scheme() != webstore_base_url.scheme() ||
159 webstore_url.host() != webstore_base_url.host() || 159 webstore_url.host() != webstore_base_url.host() ||
160 !base::StartsWith(webstore_url.path(), webstore_base_url.path(), 160 !base::StartsWith(webstore_url.path(), webstore_base_url.path(),
161 base::CompareCase::SENSITIVE)) { 161 base::CompareCase::SENSITIVE)) {
162 *error = kInvalidWebstoreItemUrlError; 162 *error = kInvalidWebstoreItemUrlError;
163 return false; 163 return false;
164 } 164 }
165 165
166 std::string candidate_webstore_item_id = webstore_url.path().substr( 166 std::string candidate_webstore_item_id =
167 webstore_base_url.path().length()); 167 webstore_url.path()
168 .substr(webstore_base_url.path().length())
169 .as_string();
168 if (!crx_file::id_util::IdIsValid(candidate_webstore_item_id)) { 170 if (!crx_file::id_util::IdIsValid(candidate_webstore_item_id)) {
169 *error = kInvalidWebstoreItemUrlError; 171 *error = kInvalidWebstoreItemUrlError;
170 return false; 172 return false;
171 } 173 }
172 174
173 std::string reconstructed_webstore_item_url_string = 175 std::string reconstructed_webstore_item_url_string =
174 extension_urls::GetWebstoreItemDetailURLPrefix() + 176 extension_urls::GetWebstoreItemDetailURLPrefix() +
175 candidate_webstore_item_id; 177 candidate_webstore_item_id;
176 if (reconstructed_webstore_item_url_string != webstore_url_string) { 178 if (reconstructed_webstore_item_url_string != webstore_url_string) {
177 *error = kInvalidWebstoreItemUrlError; 179 *error = kInvalidWebstoreItemUrlError;
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 v8::Isolate* isolate = context()->isolate(); 245 v8::Isolate* isolate = context()->isolate();
244 v8::HandleScope handle_scope(isolate); 246 v8::HandleScope handle_scope(isolate);
245 v8::Context::Scope context_scope(context()->v8_context()); 247 v8::Context::Scope context_scope(context()->v8_context());
246 v8::Local<v8::Value> argv[] = { 248 v8::Local<v8::Value> argv[] = {
247 v8::Number::New(isolate, percent_downloaded / 100.0)}; 249 v8::Number::New(isolate, percent_downloaded / 100.0)};
248 context()->module_system()->CallModuleMethodSafe( 250 context()->module_system()->CallModuleMethodSafe(
249 "webstore", "onDownloadProgress", arraysize(argv), argv); 251 "webstore", "onDownloadProgress", arraysize(argv), argv);
250 } 252 }
251 253
252 } // namespace extensions 254 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/resource_request_policy.cc ('k') | chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698