[WIP] make GURL::path() return a StringPiece

chrome/browser/ui/webui/fileicon_source.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/fileicon_source.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/files/file_path.h"
 #include "base/memory/ref_counted_memory.h"
@@ skipping 24 matching lines @@
 
 // Assuming the url is of the form '/path?query', convert the path portion into
 // a FilePath and return the resulting |file_path| and |query|.  The path
 // portion may have been encoded using encodeURIComponent().
 void GetFilePathAndQuery(const std::string& url,
                          base::FilePath* file_path,
                          std::string* query) {
   // We receive the url with chrome://fileicon/ stripped but GURL expects it.
   const GURL gurl("chrome://fileicon/" + url);
   std::string path = net::UnescapeURLComponent(
-      gurl.path().substr(1),
+      gurl.path().substr(1).as_string(),
       net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS |
           net::UnescapeRule::PATH_SEPARATORS | net::UnescapeRule::SPACES);
 
   *file_path = base::FilePath::FromUTF8Unsafe(path);
   *file_path = file_path->NormalizePathSeparators();
   query->assign(gurl.query());
 }
 
 IconLoader::IconSize SizeStringToIconSize(const std::string& size_string) {
   if (size_string == "small") return IconLoader::SMALL;
@@ skipping 99 matching lines @@
             details.scale_factor).sk_bitmap(),
         false,
         &icon_data->data());
 
     details.callback.Run(icon_data.get());
   } else {
     // TODO(glen): send a dummy icon.
     details.callback.Run(NULL);
   }
 }