[WIP] make GURL::path() return a StringPiece

chrome/browser/ui/webui/devtools_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/devtools_ui.h"
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/strings/string_split.h"
@@ skipping 17 matching lines @@
 #include "net/url_request/url_request_context_getter.h"
 #include "third_party/WebKit/public/public_features.h"
 
 using content::BrowserThread;
 using content::WebContents;
 
 namespace {
 
 std::string PathWithoutParams(const std::string& path) {
   return GURL(std::string("chrome-devtools://devtools/") + path)
-      .path().substr(1);
+      .path()
+      .substr(1)
+      .as_string();
 }
 
 const char kRemoteFrontendDomain[] = "chrome-devtools-frontend.appspot.com";
 const char kRemoteFrontendBase[] =
     "https://chrome-devtools-frontend.appspot.com/";
 const char kRemoteFrontendPath[] = "serve_file";
 const char kHttpNotFound[] = "HTTP/1.1 404 Not Found\n\n";
 
 #if BUILDFLAG(DEBUG_DEVTOOLS)
 // Local frontend url provided by InspectUI.
@@ skipping 39 matching lines @@
 
 std::string SanitizeEndpoint(const std::string& value) {
   if (value.find('&') != std::string::npos
       || value.find('?') != std::string::npos)
     return std::string();
   return value;
 }
 
 std::string SanitizeRemoteBase(const std::string& value) {
   GURL url(value);
-  std::string path = url.path();
+  std::string path = url.path().as_string();
   std::vector<std::string> parts = base::SplitString(
       path, "/", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
   std::string revision = parts.size() > 2 ? parts[2] : "";
   revision = SanitizeRevision(revision);
   path = base::StringPrintf("/%s/%s/", kRemoteFrontendPath, revision.c_str());
   return SanitizeFrontendURL(url, url::kHttpsScheme,
                              kRemoteFrontendDomain, path, false).spec();
 }
 
 std::string SanitizeRemoteFrontendURL(const std::string& value) {
   GURL url(net::UnescapeURLComponent(value,
       net::UnescapeRule::SPACES | net::UnescapeRule::PATH_SEPARATORS |
       net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS |
       net::UnescapeRule::REPLACE_PLUS_WITH_SPACE));
-  std::string path = url.path();
+  std::string path = url.path().as_string();
   std::vector<std::string> parts = base::SplitString(
       path, "/", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
   std::string revision = parts.size() > 2 ? parts[2] : "";
   revision = SanitizeRevision(revision);
   std::string filename = parts.size() ? parts[parts.size() - 1] : "";
   if (filename != "devtools.html")
     filename = "inspector.html";
   path = base::StringPrintf("/serve_rev/%s/%s",
                             revision.c_str(), filename.c_str());
   std::string sanitized = SanitizeFrontendURL(url, url::kHttpsScheme,
@@ skipping 276 matching lines @@
 
 }  // namespace
 
 // DevToolsUI -----------------------------------------------------------------
 
 // static
 GURL DevToolsUI::GetProxyURL(const std::string& frontend_url) {
   GURL url(frontend_url);
   if (!url.is_valid() || url.host() != kRemoteFrontendDomain)
     return GURL(kFallbackFrontendURL);
-  return GURL(base::StringPrintf("%s://%s/%s/%s",
-              content::kChromeDevToolsScheme,
-              chrome::kChromeUIDevToolsHost,
-              chrome::kChromeUIDevToolsRemotePath,
-              url.path().substr(1).c_str()));
+  return GURL(base::StringPrintf(
+      "%s://%s/%s/%s", content::kChromeDevToolsScheme,
+      chrome::kChromeUIDevToolsHost, chrome::kChromeUIDevToolsRemotePath,
+      url.path().substr(1).as_string().c_str()));
 }
 
 // static
 GURL DevToolsUI::GetRemoteBaseURL() {
   return GURL(base::StringPrintf(
       "%s%s/%s/",
       kRemoteFrontendBase,
       kRemoteFrontendPath,
       content::GetWebKitRevision().c_str()));
 }
 
 // static
 GURL DevToolsUI::SanitizeFrontendURL(const GURL& url) {
-  return ::SanitizeFrontendURL(url, content::kChromeDevToolsScheme,
-      chrome::kChromeUIDevToolsHost, SanitizeFrontendPath(url.path()), true);
+  return ::SanitizeFrontendURL(
+      url, content::kChromeDevToolsScheme, chrome::kChromeUIDevToolsHost,
+      SanitizeFrontendPath(url.path().as_string()), true);
 }
 
 DevToolsUI::DevToolsUI(content::WebUI* web_ui)
     : WebUIController(web_ui) {
   web_ui->SetBindings(0);
   Profile* profile = Profile::FromWebUI(web_ui);
   content::URLDataSource::Add(
       profile,
       new DevToolsDataSource(profile->GetRequestContext()));
 
   GURL url = web_ui->GetWebContents()->GetVisibleURL();
   if (url.spec() == SanitizeFrontendURL(url).spec())
     bindings_.reset(new DevToolsUIBindings(web_ui->GetWebContents()));
 }
 
 DevToolsUI::~DevToolsUI() {
 }