[WIP] make GURL::path() return a StringPiece

chrome/browser/password_manager/password_store_mac.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_store_mac.h"
 
 #include <CoreServices/CoreServices.h>
 #include <stddef.h>
 #include <algorithm>
 #include <set>
@@ skipping 646 matching lines @@
 
   if (server)
     *server = realm_as_url.host();
   if (is_secure)
     *is_secure = realm_as_url.SchemeIsCryptographic();
   if (port)
     *port = realm_as_url.has_port() ? atoi(realm_as_url.port().c_str()) : 0;
   if (security_domain) {
     // Strip the leading '/' off of the path to get the security domain.
     if (realm_as_url.path().length() > 0)
-      *security_domain = realm_as_url.path().substr(1);
+      *security_domain = realm_as_url.path().substr(1).as_string();
     else
       security_domain->clear();
   }
   return true;
 }
 
 bool FormIsValidAndMatchesOtherForm(const PasswordForm& query_form,
                                     const PasswordForm& other_form) {
   std::string server;
   std::string security_domain;
@@ skipping 109 matching lines @@
   std::string security_domain;
   UInt32 port;
   bool is_secure;
   if (!internal_keychain_helpers::ExtractSignonRealmComponents(
            form.signon_realm, &server, &port, &is_secure, &security_domain)) {
     return false;
   }
   std::string path;
   // Path doesn't make sense for Android app credentials.
   if (!password_manager::IsValidAndroidFacetURI(form.signon_realm))
-    path = form.origin.path();
+    path = form.origin.path().as_string();
   std::string username = base::UTF16ToUTF8(form.username_value);
   std::string password = base::UTF16ToUTF8(form.password_value);
   SecProtocolType protocol = is_secure ? kSecProtocolTypeHTTPS
                                        : kSecProtocolTypeHTTP;
   SecKeychainItemRef new_item = NULL;
   OSStatus result = keychain_->AddInternetPassword(
       NULL, server.size(), server.c_str(),
       security_domain.size(), security_domain.c_str(),
       username.size(), username.c_str(),
       path.size(), path.c_str(),
@@ skipping 52 matching lines @@
     const PasswordForm& form) {
   // We don't store blacklist entries in the keychain, so the answer to "what
   // Keychain item goes with this form" is always "nothing" for blacklists.
   // Same goes for federated logins.
   if (IsLoginDatabaseOnlyForm(form))
     return NULL;
 
   std::string path;
   // Path doesn't make sense for Android app credentials.
   if (!password_manager::IsValidAndroidFacetURI(form.signon_realm))
-    path = form.origin.path();
+    path = form.origin.path().as_string();
   std::string username = base::UTF16ToUTF8(form.username_value);
   std::vector<SecKeychainItemRef> matches = MatchingKeychainItems(
       form.signon_realm, form.scheme, path.c_str(), username.c_str());
 
   if (matches.empty()) {
     return NULL;
   }
 
   // Free all items after the first, since we won't be returning them.
   for (auto i = matches.begin() + 1; i != matches.end(); ++i)
@@ skipping 539 matching lines @@
   ScopedVector<PasswordForm> forms_with_keychain_entry;
   internal_keychain_helpers::GetPasswordsForForms(*keychain_, &database_forms,
                                                   &forms_with_keychain_entry);
 
   // Clean up any orphaned database entries.
   RemoveDatabaseForms(&database_forms);
 
   // Move the orphaned DB forms to the output parameter.
   AppendSecondToFirst(orphaned_forms, &database_forms);
 }