Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2481883002: Create copies of the benchmark output for catapult to read. (Closed)

Created:
4 years, 1 month ago by RobertoCN
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Create copies of the benchmark output for catapult to read. This experimental change is hoped to help by ensuring that the file handle is closed before invoking compare_samples from the catapult repo. R=nednguyen@chromium.org BUG=659908 Committed: https://chromium.googlesource.com/chromium/tools/build/+/d40d63f733e7d495c2f466a854eab057346cba8d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+384 lines, -360 lines) Patch
M scripts/slave/recipe_modules/auto_bisect_staging/api.py View 2 chunks +26 lines, -2 lines 1 comment Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_bisect_other_direction.json View 17 chunks +34 lines, -34 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_linux_bisect.json View 17 chunks +34 lines, -34 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_mac_bisect.json View 17 chunks +34 lines, -34 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win32_bisect.json View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win64_bisect.json View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_buildbucket_get.json View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_revision.json View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/no_repro.json View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/no_values.json View 23 chunks +46 lines, -46 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/retest_bisect.json View 14 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/v8_roll_bisect.json View 33 chunks +66 lines, -66 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/v8_roll_bisect_bis.json View 21 chunks +42 lines, -42 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_basic_device.json View 6 chunks +12 lines, -12 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_disconnected_device.json View 20 chunks +40 lines, -40 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_failed_device.json View 6 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
RobertoCN
PTAL
4 years, 1 month ago (2016-11-07 18:26:29 UTC) #1
dtu
lgtm https://codereview.chromium.org/2481883002/diff/1/scripts/slave/recipe_modules/auto_bisect_staging/api.py File scripts/slave/recipe_modules/auto_bisect_staging/api.py (right): https://codereview.chromium.org/2481883002/diff/1/scripts/slave/recipe_modules/auto_bisect_staging/api.py#newcode447 scripts/slave/recipe_modules/auto_bisect_staging/api.py:447: f.write(open(str(path)).read()) shutil.copyfile()?
4 years, 1 month ago (2016-11-07 19:34:24 UTC) #4
nednguyen
Who does the work of removing all these files once bisect is done?
4 years, 1 month ago (2016-11-07 20:51:47 UTC) #6
RobertoCN
On 2016/11/07 20:51:47, nednguyen wrote: > Who does the work of removing all these files ...
4 years, 1 month ago (2016-11-07 21:16:42 UTC) #7
RobertoCN
On 2016/11/07 20:51:47, nednguyen wrote: > Who does the work of removing all these files ...
4 years, 1 month ago (2016-11-07 21:16:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481883002/1
4 years, 1 month ago (2016-11-07 21:45:36 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 21:55:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/d40d63f733e7d495c2f4...

Powered by Google App Engine
This is Rietveld 408576698