Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2481843003: Worker: Add WorkerOrWorkletGlobalScope::thread() interface (Closed)

Created:
4 years, 1 month ago by nhiroki
Modified:
4 years, 1 month ago
Reviewers:
haraken
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Add WorkerOrWorkletGlobalScope::thread() interface This is a preparation for https://codereview.chromium.org/2456733002/ Before this CL, thread() is provided by WorkerGlobalScope and ThreadedWorkletGlobalScope. This is not convenient when we handle them as WorkerOrWorkletGlobalScope, a base class of both the global scopes, and want to access WorkerThread from that. In the case, we need to cast it to WorkerGlobalScope or ThreadedWorkletGlobalScope, and then call its thread(). After this CL, we can directly call WorkerOrWorkletGlobalScope::thread(). Note that MainThreadWorkletGlobalScope is also a sub-class of WorkerOrWorkletGlobalScope, but it's not associated with WorkerThread, so MainThreadWorkletGlobalScope::thread() always returns nullptr. BUG=646559 Committed: https://crrev.com/55f5c0ef44161653b49a4f2f3a8a0c9fd74ba61e Cr-Commit-Position: refs/heads/master@{#430532}

Patch Set 1 #

Messages

Total messages: 16 (11 generated)
nhiroki
PTAL, thanks.
4 years, 1 month ago (2016-11-08 05:21:28 UTC) #9
haraken
LGTM
4 years, 1 month ago (2016-11-08 05:25:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481843003/20001
4 years, 1 month ago (2016-11-08 05:41:37 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-08 06:03:28 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 06:06:05 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55f5c0ef44161653b49a4f2f3a8a0c9fd74ba61e
Cr-Commit-Position: refs/heads/master@{#430532}

Powered by Google App Engine
This is Rietveld 408576698