Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2481823003: net: append -S to python invocation in the test server (Closed)

Created:
4 years, 1 month ago by Paweł Hajdan Jr.
Modified:
4 years, 1 month ago
Reviewers:
Ryan Hamilton, mbjorge
CC:
cbentzel+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: append -S to python invocation in the test server This will force using hermetic python libraries instead of unpredictable system ones. BUG=642190 Committed: https://crrev.com/6e48309c7f714cd8afb6ded20ef4adcc6b765624 Cr-Commit-Position: refs/heads/master@{#430895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M net/test/python_utils.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Paweł Hajdan Jr.
I'm not yet sure if it'll fix the bug, but it should make things more ...
4 years, 1 month ago (2016-11-08 15:25:30 UTC) #6
Ryan Hamilton
On 2016/11/08 15:25:30, Paweł Hajdan Jr. wrote: > I'm not yet sure if it'll fix ...
4 years, 1 month ago (2016-11-08 22:11:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481823003/1
4 years, 1 month ago (2016-11-09 08:47:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 08:51:01 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6e48309c7f714cd8afb6ded20ef4adcc6b765624 Cr-Commit-Position: refs/heads/master@{#430895}
4 years, 1 month ago (2016-11-09 08:53:29 UTC) #12
mbjorge
This CL broke running net_unittests on the cast CQ internally. Our CQ runs with a ...
4 years, 1 month ago (2016-11-22 18:57:38 UTC) #14
mbjorge
4 years, 1 month ago (2016-11-22 19:49:18 UTC) #15
Message was sent while issue was closed.
Adding a -S has broken virtualenv's before. In another example, a check was done
where if we were in a virtualenv already, then the -S flag was not added
(https://codereview.chromium.org/2341173004/).

I'm not sure the best way to detect the presence of a virtualenv form C++ is
though. The preferred way in python, as done in the linked CL, is to check if
the sys module has a 'real_prefix' attribute. But if that's not feasible,
perhaps it would be easier to check for the presenence of the VIRTUAL_ENV
environment variable?

Powered by Google App Engine
This is Rietveld 408576698