Push preg_parser and registry_dict changes upstream

Push preg_parser and registry_dict changes upstream

preg_parser and registry_dict are used in Chromium OS by authpolicy
code to fetch policy from AD servers. Right now, a custom version of
the two files is checked into platform2 in Chromium OS. This CL
pushes changes made to these files upstream to Chromium, in particular
making them compile outside of Windows. The goal is to eventually use
them in libchrome, so that only one version of the code has to be
maintained and unit tests can be reused.

Both files are compiled for Windows and Chrome OS, even though only
the Windows version is used in Chromium. This is done to ensure the
file compiles OK and won't cause an issue downstream when used in
Chrome OS.

The i18n UTF16 ToLower method has been replaced by an ASCII method for two reasons:
- We don't need it, we always check for ASCII keys. Keys and values are actually converted to UTF8 later and compared using case-insensitive ASCII checks, so if it was a problem, it would already surface.
- More importantly, using i18n would introduce a dependency in Chrome OS on the third-party library icu and we don't want to pull this in.

RegistryDict::ConvertToJSON has been #ifdef'ed out in Chrome OS because it would pull in some dependencies and it is not needed right now.

BUG=chromium:659645
TEST=Compiled on Linux and ran unit tests

Committed: https://crrev.com/32d00fec960c4005730cdb13a51a8416340638e9
Cr-Commit-Position: refs/heads/master@{#432908}

[ljusten (tachyonic), 2016-11-07 11:32:07]

The CQ bit was checked by ljusten@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 11:32:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 11:40:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 11:40:15]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[ljusten (tachyonic), 2016-11-07 12:29:28]

The CQ bit was checked by ljusten@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 12:29:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 12:41:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 12:41:56]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[ljusten (tachyonic), 2016-11-07 13:31:27]

The CQ bit was checked by ljusten@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 13:31:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 14:07:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 14:07:24]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ljusten (tachyonic), 2016-11-07 14:37:40]

The CQ bit was checked by ljusten@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 14:37:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 16:21:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 16:21:38]

Dry run: This issue passed the CQ dry run.

[ljusten (tachyonic), 2016-11-09 10:04:12]

Description was changed from

==========
Push preg_parser and registry_dict changes upstream

preg_parser and registry_dict are used in Chromium OS by authpolicy
code to fetch policy from AD servers. Right now, a custom version of
the two files is checked into platform2 in Chromium OS. This CL
pushes changes made to these files upstream to Chromium, in particular
making them compile outside of Windows. The goal is to eventually use
them in libchrome, so that only one version of the code has to be
maintained and unit tests can be reused.

BUG=chromium:659645
TEST=Compiled on Linux and ran unit tests
==========

to

==========
Push preg_parser and registry_dict changes upstream

preg_parser and registry_dict are used in Chromium OS by authpolicy
code to fetch policy from AD servers. Right now, a custom version of
the two files is checked into platform2 in Chromium OS. This CL
pushes changes made to these files upstream to Chromium, in particular
making them compile outside of Windows. The goal is to eventually use
them in libchrome, so that only one version of the code has to be
maintained and unit tests can be reused.

Both files are compiled for Windows and Chrome OS, even though only
the Windows version is used in Chromium. This is done to ensure the
file compiles OK and won't cause an issue downstream when used in
Chrome OS.

BUG=chromium:659645
TEST=Compiled on Linux and ran unit tests
==========

[ljusten (tachyonic), 2016-11-09 12:01:00]

Description was changed from

==========
Push preg_parser and registry_dict changes upstream

preg_parser and registry_dict are used in Chromium OS by authpolicy
code to fetch policy from AD servers. Right now, a custom version of
the two files is checked into platform2 in Chromium OS. This CL
pushes changes made to these files upstream to Chromium, in particular
making them compile outside of Windows. The goal is to eventually use
them in libchrome, so that only one version of the code has to be
maintained and unit tests can be reused.

Both files are compiled for Windows and Chrome OS, even though only
the Windows version is used in Chromium. This is done to ensure the
file compiles OK and won't cause an issue downstream when used in
Chrome OS.

BUG=chromium:659645
TEST=Compiled on Linux and ran unit tests
==========

to

==========
Push preg_parser and registry_dict changes upstream

preg_parser and registry_dict are used in Chromium OS by authpolicy
code to fetch policy from AD servers. Right now, a custom version of
the two files is checked into platform2 in Chromium OS. This CL
pushes changes made to these files upstream to Chromium, in particular
making them compile outside of Windows. The goal is to eventually use
them in libchrome, so that only one version of the code has to be
maintained and unit tests can be reused.

Both files are compiled for Windows and Chrome OS, even though only
the Windows version is used in Chromium. This is done to ensure the
file compiles OK and won't cause an issue downstream when used in
Chrome OS.

The i18n UTF16 ToLower method has been replaced by an ASCII method for two
reasons:
- We don't need it, we always check for ASCII keys. Keys and values are actually
converted to UTF8 later and compared using case-insensitive ASCII checks, so if
it was a problem, it would already surface.
- More importantly, using i18n would introduce a dependency in Chrome OS on the
third-party library icu and we don't want to pull this in.

BUG=chromium:659645
TEST=Compiled on Linux and ran unit tests
==========

[ljusten (tachyonic), 2016-11-09 12:07:18]

Description was changed from

==========
Push preg_parser and registry_dict changes upstream

preg_parser and registry_dict are used in Chromium OS by authpolicy
code to fetch policy from AD servers. Right now, a custom version of
the two files is checked into platform2 in Chromium OS. This CL
pushes changes made to these files upstream to Chromium, in particular
making them compile outside of Windows. The goal is to eventually use
them in libchrome, so that only one version of the code has to be
maintained and unit tests can be reused.

Both files are compiled for Windows and Chrome OS, even though only
the Windows version is used in Chromium. This is done to ensure the
file compiles OK and won't cause an issue downstream when used in
Chrome OS.

The i18n UTF16 ToLower method has been replaced by an ASCII method for two
reasons:
- We don't need it, we always check for ASCII keys. Keys and values are actually
converted to UTF8 later and compared using case-insensitive ASCII checks, so if
it was a problem, it would already surface.
- More importantly, using i18n would introduce a dependency in Chrome OS on the
third-party library icu and we don't want to pull this in.

BUG=chromium:659645
TEST=Compiled on Linux and ran unit tests
==========

to

==========
Push preg_parser and registry_dict changes upstream

preg_parser and registry_dict are used in Chromium OS by authpolicy
code to fetch policy from AD servers. Right now, a custom version of
the two files is checked into platform2 in Chromium OS. This CL
pushes changes made to these files upstream to Chromium, in particular
making them compile outside of Windows. The goal is to eventually use
them in libchrome, so that only one version of the code has to be
maintained and unit tests can be reused.

Both files are compiled for Windows and Chrome OS, even though only
the Windows version is used in Chromium. This is done to ensure the
file compiles OK and won't cause an issue downstream when used in
Chrome OS.

The i18n UTF16 ToLower method has been replaced by an ASCII method for two
reasons:
- We don't need it, we always check for ASCII keys. Keys and values are actually
converted to UTF8 later and compared using case-insensitive ASCII checks, so if
it was a problem, it would already surface.
- More importantly, using i18n would introduce a dependency in Chrome OS on the
third-party library icu and we don't want to pull this in.

RegistryDict::ConvertToJSON has been #ifdef'ed out in Chrome OS because it would
pull in some dependencies and it is not needed right now.

BUG=chromium:659645
TEST=Compiled on Linux and ran unit tests
==========

[ljusten (tachyonic), 2016-11-09 12:09:51]

The CQ bit was checked by ljusten@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 12:10:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ljusten (tachyonic), 2016-11-09 12:13:29]

ljusten@chromium.org changed reviewers:
+ pastarmovj@chromium.org

[ljusten (tachyonic), 2016-11-09 12:13:30]

Julian, these are changes to preg_parser and registry_dict to make them compile
for Chrome OS. Right now, similar changes are in the Chrome OS code base
(reviewed by mnissler). Do you see any problems with replacing the i18n UTF16
ToLower function with an ASCII check in preg_parser (see CL description for a
reasoning)?

[pastarmovj, 2016-11-09 12:26:06]

https://codereview.chromium.org/2481753002/diff/80001/components/policy/core/...
File components/policy/core/common/preg_parser.cc (right):

https://codereview.chromium.org/2481753002/diff/80001/components/policy/core/...
components/policy/core/common/preg_parser.cc:216: if (action_trigger ==
kActionTriggerDeleteValues) {
please revert.

https://codereview.chromium.org/2481753002/diff/80001/components/policy/core/...
components/policy/core/common/preg_parser.cc:229: dict->RemoveValue(
ditto.

https://codereview.chromium.org/2481753002/diff/80001/components/policy/core/...
components/policy/core/common/preg_parser.cc:335: if (base::StartsWith(key_name,
root, base::CompareCase::INSENSITIVE_ASCII))
I just wonder if this can be used as a way to trick this code to read something
else if by using unicode chars you can make it look like the ascii names of our
keys?

[commit-bot: I haz the power, 2016-11-09 13:02:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 13:02:52]

Dry run: This issue passed the CQ dry run.

[ljusten (tachyonic), 2016-11-09 15:09:56]

https://codereview.chromium.org/2481753002/diff/80001/components/policy/core/...
File components/policy/core/common/preg_parser.cc (right):

https://codereview.chromium.org/2481753002/diff/80001/components/policy/core/...
components/policy/core/common/preg_parser.cc:216: if (action_trigger ==
kActionTriggerDeleteValues) {
On 2016/11/09 12:26:06, pastarmovj wrote:
> please revert.

Done.

https://codereview.chromium.org/2481753002/diff/80001/components/policy/core/...
components/policy/core/common/preg_parser.cc:229: dict->RemoveValue(
On 2016/11/09 12:26:06, pastarmovj wrote:
> ditto.

Done.

https://codereview.chromium.org/2481753002/diff/80001/components/policy/core/...
components/policy/core/common/preg_parser.cc:335: if (base::StartsWith(key_name,
root, base::CompareCase::INSENSITIVE_ASCII))
On 2016/11/09 12:26:06, pastarmovj wrote:
> I just wonder if this can be used as a way to trick this code to read
something
> else if by using unicode chars you can make it look like the ascii names of
our
> keys?

This is not possible. Here's the proof:

Theorem
-------
Let key_name and root be two String16s and let root be ASCII.
If
  base::StartsWith(key_name, root, base::CompareCase::INSENSITIVE_ASCII)
returns true, then the first N := root.size() characters of key_name are ASCII.

Proof
-----
By the nature of base::StartsWith(), the first N Char16s of key_name and root
compare true using CaseInsensitiveCompareASCII. That means, for each of the
first N Char16s, c1 of key_name and c2 of root,
  (c1 >= 'A' && c1 <= 'Z') ? (c1 + ('a' - 'A')) : c1
is equal to
  (c2 >= 'A' && c2 <= 'Z') ? (c2 + ('a' - 'A')) : c2;
If c1 were not ASCII, it would be outside of ['A', 'Z'] and hence c2 would not
be ASCII - a contradiction, since root is ASCII. Therefore, the first N Char16s
of key_name are ASCII.

q.e.d.

[pastarmovj, 2016-11-17 15:09:17]

lgtm

[ljusten (tachyonic), 2016-11-17 15:15:03]

The CQ bit was checked by ljusten@chromium.org

[commit-bot: I haz the power, 2016-11-17 15:15:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 17:55:29]

Description was changed from

==========
Push preg_parser and registry_dict changes upstream

preg_parser and registry_dict are used in Chromium OS by authpolicy
code to fetch policy from AD servers. Right now, a custom version of
the two files is checked into platform2 in Chromium OS. This CL
pushes changes made to these files upstream to Chromium, in particular
making them compile outside of Windows. The goal is to eventually use
them in libchrome, so that only one version of the code has to be
maintained and unit tests can be reused.

Both files are compiled for Windows and Chrome OS, even though only
the Windows version is used in Chromium. This is done to ensure the
file compiles OK and won't cause an issue downstream when used in
Chrome OS.

The i18n UTF16 ToLower method has been replaced by an ASCII method for two
reasons:
- We don't need it, we always check for ASCII keys. Keys and values are actually
converted to UTF8 later and compared using case-insensitive ASCII checks, so if
it was a problem, it would already surface.
- More importantly, using i18n would introduce a dependency in Chrome OS on the
third-party library icu and we don't want to pull this in.

RegistryDict::ConvertToJSON has been #ifdef'ed out in Chrome OS because it would
pull in some dependencies and it is not needed right now.

BUG=chromium:659645
TEST=Compiled on Linux and ran unit tests
==========

to

==========
Push preg_parser and registry_dict changes upstream

preg_parser and registry_dict are used in Chromium OS by authpolicy
code to fetch policy from AD servers. Right now, a custom version of
the two files is checked into platform2 in Chromium OS. This CL
pushes changes made to these files upstream to Chromium, in particular
making them compile outside of Windows. The goal is to eventually use
them in libchrome, so that only one version of the code has to be
maintained and unit tests can be reused.

Both files are compiled for Windows and Chrome OS, even though only
the Windows version is used in Chromium. This is done to ensure the
file compiles OK and won't cause an issue downstream when used in
Chrome OS.

The i18n UTF16 ToLower method has been replaced by an ASCII method for two
reasons:
- We don't need it, we always check for ASCII keys. Keys and values are actually
converted to UTF8 later and compared using case-insensitive ASCII checks, so if
it was a problem, it would already surface.
- More importantly, using i18n would introduce a dependency in Chrome OS on the
third-party library icu and we don't want to pull this in.

RegistryDict::ConvertToJSON has been #ifdef'ed out in Chrome OS because it would
pull in some dependencies and it is not needed right now.

BUG=chromium:659645
TEST=Compiled on Linux and ran unit tests
==========

[commit-bot: I haz the power, 2016-11-17 17:55:30]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-17 18:09:04]

Description was changed from

==========
Push preg_parser and registry_dict changes upstream

preg_parser and registry_dict are used in Chromium OS by authpolicy
code to fetch policy from AD servers. Right now, a custom version of
the two files is checked into platform2 in Chromium OS. This CL
pushes changes made to these files upstream to Chromium, in particular
making them compile outside of Windows. The goal is to eventually use
them in libchrome, so that only one version of the code has to be
maintained and unit tests can be reused.

Both files are compiled for Windows and Chrome OS, even though only
the Windows version is used in Chromium. This is done to ensure the
file compiles OK and won't cause an issue downstream when used in
Chrome OS.

The i18n UTF16 ToLower method has been replaced by an ASCII method for two
reasons:
- We don't need it, we always check for ASCII keys. Keys and values are actually
converted to UTF8 later and compared using case-insensitive ASCII checks, so if
it was a problem, it would already surface.
- More importantly, using i18n would introduce a dependency in Chrome OS on the
third-party library icu and we don't want to pull this in.

RegistryDict::ConvertToJSON has been #ifdef'ed out in Chrome OS because it would
pull in some dependencies and it is not needed right now.

BUG=chromium:659645
TEST=Compiled on Linux and ran unit tests
==========

to

==========
Push preg_parser and registry_dict changes upstream

preg_parser and registry_dict are used in Chromium OS by authpolicy
code to fetch policy from AD servers. Right now, a custom version of
the two files is checked into platform2 in Chromium OS. This CL
pushes changes made to these files upstream to Chromium, in particular
making them compile outside of Windows. The goal is to eventually use
them in libchrome, so that only one version of the code has to be
maintained and unit tests can be reused.

Both files are compiled for Windows and Chrome OS, even though only
the Windows version is used in Chromium. This is done to ensure the
file compiles OK and won't cause an issue downstream when used in
Chrome OS.

The i18n UTF16 ToLower method has been replaced by an ASCII method for two
reasons:
- We don't need it, we always check for ASCII keys. Keys and values are actually
converted to UTF8 later and compared using case-insensitive ASCII checks, so if
it was a problem, it would already surface.
- More importantly, using i18n would introduce a dependency in Chrome OS on the
third-party library icu and we don't want to pull this in.

RegistryDict::ConvertToJSON has been #ifdef'ed out in Chrome OS because it would
pull in some dependencies and it is not needed right now.

BUG=chromium:659645
TEST=Compiled on Linux and ran unit tests

Committed: https://crrev.com/32d00fec960c4005730cdb13a51a8416340638e9
Cr-Commit-Position: refs/heads/master@{#432908}
==========

[commit-bot: I haz the power, 2016-11-17 18:09:06]

Patchset 6 (id:??) landed as
https://crrev.com/32d00fec960c4005730cdb13a51a8416340638e9
Cr-Commit-Position: refs/heads/master@{#432908}